thr3ads.net - wxruby development - [Wxruby-development] [944] trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb: Fix bug with endless recursion on not-found items in find

If this information is useful, please help other people find it:
Share via:

nobody at rubyforge.org

2007-Apr-03 18:54 UTC

[Wxruby-development] [944] trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb: Fix bug with endless recursion on not-found items in find_string

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type"
content="text/html; charset=utf-8" /><style
type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:'':'';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family:
verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;
font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding:
6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid;
padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family:
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch
.binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[944] trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb: Fix bug
with endless recursion on not-found items in find_string</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd>944</dd>
<dt>Author</dt> <dd>brokentoy</dd>
<dt>Date</dt> <dd>2007-04-03 14:54:48 -0400 (Tue, 03 Apr
2007)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix bug with endless recursion on not-found items in
find_string</pre>

<h3>Modified Paths</h3>
<ul>
<li><a
href="#trunkwxsugarlibwx_sugarwx_classeslistctrlrb">trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwxsugarlibwx_sugarwx_classeslistctrlrb"></a>
<div class="modfile"><h4>Modified:
trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb (943 => 944)</h4>
<pre class="diff"><span>
<span class="info">---
trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-04-03
18:46:45 UTC (rev 943)
+++
trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-04-03
18:54:48 UTC (rev 944)
</span><span class="lines">@@ -14,7 +14,8 @@
</span><span class="cx">     insert_item(get_item_count,
str)
</span><span class="cx">   end
</span><span class="cx"> 
</span><del>-  # Emulate the ControlWithItems find_string method.
</del><ins>+  # Emulate the ControlWithItems find_string method.
Like the cognate
+  # method, it returns -1 if the string was not found.
</ins><span class="cx">   def find_string(str,
case_sensitive = false)
</span><span class="cx">     if case_sensitive
</span><span class="cx">      
find_string_sensitively(str)
</span><span class="lines">@@ -29,6 +30,7 @@
</span><span class="cx">   def
find_string_sensitively(str)
</span><span class="cx">     start = -1
</span><span class="cx">     until found =
find_item(start, str) and get_item_text(found) == str
</span><ins>+      break if found == -1 # Not found at all
</ins><span class="cx">       start = found + 1
</span><span class="cx">     end
</span><span class="cx">     return found
</span></span></pre>
</div>
</div>

</body>
</html>

Possibly Parallel Threads

Search for more apparently analagous threads

wxruby development - Apr 2007 - [944] trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb: Fix bug with endless recursion on not-found items in find_string

[Wxruby-development] [944] trunk/wxsugar/lib/wx_sugar/wx_classes/listctrl.rb: Fix bug with endless recursion on not-found items in find_string

Possibly Parallel Threads

Wisdom of the Ancients