thr3ads.net - wxruby development - [Wxruby-development] [927] branches/wxruby2/wxwidgets_282/swig/classes: Changed the version of InsertItem that puts the item before current selection to InsertItemBefore [Mar 2007]

If this information is useful, please help other people find it:
Share via:

nobody at rubyforge.org

2007-Mar-29 21:53 UTC

[Wxruby-development] [927] branches/wxruby2/wxwidgets_282/swig/classes: Changed the version of InsertItem that puts the item before current selection to InsertItemBefore

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type"
content="text/html; charset=utf-8" /><style
type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:'':'';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family:
verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;
font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding:
6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid;
padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family:
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch
.binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[927] branches/wxruby2/wxwidgets_282/swig/classes: Changed the
version of InsertItem that puts the item before current selection to
InsertItemBefore</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd>927</dd>
<dt>Author</dt> <dd>seanlong</dd>
<dt>Date</dt> <dd>2007-03-29 17:53:20 -0400 (Thu, 29 Mar
2007)</dd>
</dl>

<h3>Log Message</h3>
<pre>Changed the version of InsertItem that puts the item before current
selection to InsertItemBefore
to match wxPython and clear up the ambiguity for SWIG.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a
href="#brancheswxruby2wxwidgets_282swigclassesTreeCtrli">branches/wxruby2/wxwidgets_282/swig/classes/TreeCtrl.i</a></li>
<li><a
href="#brancheswxruby2wxwidgets_282swigclassesincludewxTreeCtrlh">branches/wxruby2/wxwidgets_282/swig/classes/include/wxTreeCtrl.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a
id="brancheswxruby2wxwidgets_282swigclassesTreeCtrli"></a>
<div class="modfile"><h4>Modified:
branches/wxruby2/wxwidgets_282/swig/classes/TreeCtrl.i (926 =>
927)</h4>
<pre class="diff"><span>
<span class="info">---
branches/wxruby2/wxwidgets_282/swig/classes/TreeCtrl.i&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-03-29
18:51:36 UTC (rev 926)
+++
branches/wxruby2/wxwidgets_282/swig/classes/TreeCtrl.i&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-03-29
21:53:20 UTC (rev 927)
</span><span class="lines">@@ -130,5 +130,17 @@
</span><span class="cx">
&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp
</span><span class="cx">
&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbspreturn
array;&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp
</span><span class="cx">
&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp}
</span><ins>+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp//Changed
this version of insert_item to insert_item_before so SWIG
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp//does
not get confused between the 2 method signatures
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp//This
behavior matches that used by wxPython.
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbspwxTreeItemId
insert_item_before(const wxTreeItemId& parent,
+                          size_t index,
+                          const wxString& text,
+                          int image = -1, int selectedImage = -1,
+                          wxTreeItemData *data = NULL)
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp{
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbspreturn
self->InsertItem(parent,index,text,image,selectedImage,data);
+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp}
</ins><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a
id="brancheswxruby2wxwidgets_282swigclassesincludewxTreeCtrlh"></a>
<div class="modfile"><h4>Modified:
branches/wxruby2/wxwidgets_282/swig/classes/include/wxTreeCtrl.h (926 =>
927)</h4>
<pre class="diff"><span>
<span class="info">---
branches/wxruby2/wxwidgets_282/swig/classes/include/wxTreeCtrl.h&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-03-29
18:51:36 UTC (rev 926)
+++
branches/wxruby2/wxwidgets_282/swig/classes/include/wxTreeCtrl.h&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-03-29
21:53:20 UTC (rev 927)
</span><span class="lines">@@ -234,12 +234,13 @@
</span><span class="cx">                             int
image = -1, int selectedImage = -1,
</span><span class="cx">                            
wxTreeItemData *data = NULL);
</span><span class="cx"> 
</span><ins>+&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp//
NOTE! - This version of InsertItem is implemented in the .i file, as
insert_item_before
</ins><span class="cx">         // insert a new item
before the one with the given index
</span><del>-    virtual wxTreeItemId InsertItem(const
wxTreeItemId& parent,
-                            size_t index,
-                            const wxString& text,
-                            int image = -1, int selectedImage = -1,
-                            wxTreeItemData *data = NULL);
</del><ins>+    //virtual wxTreeItemId InsertItem(const
wxTreeItemId& parent,
+    //                        size_t index,
+    //                        const wxString& text,
+    //                        int image = -1, int selectedImage = -1,
+    //                        wxTreeItemData *data = NULL);
</ins><span class="cx"> 
</span><span class="cx">         // insert a new item in
as the last child of the parent
</span><span class="cx">     virtual wxTreeItemId
AppendItem(const wxTreeItemId& parent,
</span></span></pre>
</div>
</div>

</body>
</html>

Possibly Parallel Threads

Search for more apparently analagous threads

wxruby development - Mar 2007 - [927] branches/wxruby2/wxwidgets_282/swig/classes: Changed the version of InsertItem that puts the item before current selection to InsertItemBefore

[Wxruby-development] [927] branches/wxruby2/wxwidgets_282/swig/classes: Changed the version of InsertItem that puts the item before current selection to InsertItemBefore

Possibly Parallel Threads

Wisdom of the Ancients