wxPen.h #ifdefs out the stipple constructor for GTK but Pen.i %ignores the stipple functions (GetStipple, SetStipple). Shouldn''t we follow the same path so we get GetStipple and SetStipple on Mac and Windows? I didn''t attach a patch. Too tired. Hopefully someone else can whip that into shape. :) Roy
Roy Sutton wrote:> wxPen.h #ifdefs out the stipple constructor for GTK but Pen.i %ignores > the stipple functions (GetStipple, SetStipple). Shouldn''t we follow the > same path so we get GetStipple and SetStipple on Mac and Windows?Try the attached. It required a small change to header where the docs we generated from are wrong. thanks alex -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: pen_stipple.patch Url: http://rubyforge.org/pipermail/wxruby-development/attachments/20061019/4dcd6976/attachment.pl
Roy Sutton wrote:> wxPen.h #ifdefs out the stipple constructor for GTK but Pen.i %ignores > the stipple functions (GetStipple, SetStipple). Shouldn''t we follow the > same path so we get GetStipple and SetStipple on Mac and Windows?Sorry, this is the correct patch with your previous change applied. alex -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: pen_stipple.patch Url: http://rubyforge.org/pipermail/wxruby-development/attachments/20061019/d0a299da/attachment.ksh
Alex Fenton wrote:> Roy Sutton wrote: >> wxPen.h #ifdefs out the stipple constructor for GTK but Pen.i >> %ignores the stipple functions (GetStipple, SetStipple). Shouldn''t >> we follow the same path so we get GetStipple and SetStipple on Mac >> and Windows? > Sorry, this is the correct patch with your previous change applied. >Alex, this patch looks the same as the previous one to me. How''s this look? Roy -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: wxPen.h.patch Url: http://rubyforge.org/pipermail/wxruby-development/attachments/20061019/095dbc17/attachment.pl
Roy Sutton wrote:> Alex, this patch looks the same as the previous one to me. How''s this > look? >The change was the same, the context in Pen.i was wrong in the old one b/c I didn''t apply your previous change first. Though I expect you''d have figured it out ;). I don''t have Linux so I don''t know if GetStipple and SetStipple actually need to be undef''d. If you think yes or probably, please apply. Have a great time at RubyConf btw. We should have got ya a WxRuby T-shirt and baseball cap to wear! Thanks alex
Maybe Matching Threads
- [695] trunk/wxruby2/swig/classes/include/wxPen.h: Get/SetStipple not available on GTK
- [696] trunk/wxruby2/swig/classes/Pen.i: Un-ignored Get/SetStipple b/c these are now ifdef''d in the header for GTK
- [687] trunk/wxruby2/swig/classes/Pen.i: Remove a malformed and unneeded typemap (Roy Sutton)
- [1000] branches/wxruby2/wxwidgets_282/swig/classes/include/wxPen.h: Default arguments for Wx::Pen constructors
- [703] trunk/wxruby2/Changelog: Get/SetStipple for Wx::Pen; faster building on dual core; MDI sample bugs on OS X