Yuri Gribov
2018-Apr-27 20:40 UTC
[Vorbis-dev] [RFC][PATCH] Remove private symbols from Vorbis shared libs
Hi all, I recently noticed that Vorbis shlibs export several symbols which are not present in it's public header (for a total of 85 symbols, see attach). Would it make sense to filter them via -fvisibility=hidden and -Wl,--version-script? I attached a draft patch. Best regards, Yury Gribov -------------- next part -------------- _book_maptype1_quantvals _book_unquantize __bss_start drft_backward drft_clear drft_forward drft_init _edata _end _fini _float32_pack _float32_unpack floor0_exportbundle floor1_encode floor1_exportbundle floor1_fit floor1_interpolate_fit _floor_P _init _make_words mapping0_exportbundle _mapping_P mdct_backward mdct_clear mdct_forward mdct_init ov_ilog res0_free_info res0_free_look res0_inverse res0_look res0_pack res0_unpack res1_class res1_forward res1_inverse res2_class res2_forward res2_inverse residue0_exportbundle residue1_exportbundle residue2_exportbundle _residue_P _ve_envelope_clear _ve_envelope_init _ve_envelope_mark _ve_envelope_search _ve_envelope_shift _vi_gpsy_free _vi_psy_free _vorbis_apply_window vorbis_bitrate_clear vorbis_bitrate_init vorbis_bitrate_managed _vorbis_block_alloc _vorbis_block_ripcord vorbis_book_clear vorbis_book_codelen vorbis_book_codeword vorbis_book_decode vorbis_book_decodev_add vorbis_book_decodevs_add vorbis_book_decodev_set vorbis_book_decodevv_add vorbis_book_encode vorbis_book_init_decode vorbis_book_init_encode vorbis_lpc_from_data vorbis_lpc_predict vorbis_lpc_to_lsp vorbis_lsp_to_curve vorbis_staticbook_destroy vorbis_staticbook_pack vorbis_staticbook_unpack vorbis_window _vorbis_window_get _vp_ampmax_decay _vp_couple_quantize_normalize _vp_global_free _vp_global_look _vp_noisemask _vp_offset_and_mix _vp_psy_clear _vp_psy_init _vp_tonemask -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Hide-private-symbols.patch Type: application/octet-stream Size: 17385 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/vorbis-dev/attachments/20180427/a5a51eeb/attachment-0001.obj>