All, We've accumulated quite a few changes to libvorbis since the 1.2.0 release. I'd like to do a new one, a propose that 1.2.1 happen May 5 or so. So, if you have any outstanding issues, please mention them here, and please check that current svn is working for you. Thanks, -r
Here's the current changelog, if you're curious what's new since
1.2.0:
* improved robustness with corrupt streams
* new ov_read_filter() vorbisfile call allows filtering decoded
audio as floats before converting to integer samples.
* Updated RTP payload format draft.
* Bare bones self test under 'make check'
* Fix a problem encoding some streams between 14 and 28 kHz.
* Fix a numerical instability in the edge extrapolation filter.
* Build system improvements.
* Specification correction.
-r
I had a look at (mainly) Makefile.am and observed a few things
I personally would like to change unless there are objections:
- libvorbis.spec is generated but it is shipped through EXTRA_DIST?
- I'd love to see us help promiting LZMA and also produce .tar.lzma
files. How about fixing AUTOMAKE_OPTIONS with 1.10.1 and dist-lzma?
And a few cosmetics:
- EXTRA_DIST lists seven .in files though they get auto-added
as there appear in AC_OUTPUT. COPYING is also auto-added.
- The change log is called CHANGES. Why not the Autotools-usual
name ChangeLog?
- Rename configure.in to configure.ac?
Sebastian
Running ./autogen.sh from revision 14827 gives me ./configure: line 20113: syntax error near unexpected token `OGG,' ./configure: line 20113: ` PKG_CHECK_MODULES(OGG, ogg >= 1.0, HAVE_OGG=yes, HAVE_OGG=no)' on Cygwin. Sebastian
On 3-May-08, at 8:15 AM, Sebastian Pipping wrote:> - libvorbis.spec is generated but it is shipped through EXTRA_DIST?How do you suggest we ship it?> - I'd love to see us help promiting LZMA and also produce .tar.lzma > files. How about fixing AUTOMAKE_OPTIONS with 1.10.1 and dist-lzma?I'd rather this get done manually until lzma is more widely supported. I don't mind you want to post an lzma version.> - EXTRA_DIST lists seven .in files though they get auto-added > as there appear in AC_OUTPUT. COPYING is also auto-added.Which version of automake did this start happenning? :)> - The change log is called CHANGES. Why not the Autotools-usual > name ChangeLog?Because it doesn't follow the ChangeLog format. It's just a summary of major changes; I find the per-commit format redundant when there's a public version control repository.> - Rename configure.in to configure.ac?That's fine at this point. -r
I stumbled upon an oddity in autogen.sh:
The current for loop favors old aclocal versions
before new ones:
for am in automake-$AM_NEEDED automake$AM_NEEDED \
automake automake-1.7 automake-1.8 automake-1.9 \
automake-1.10; do
My Cygwin has aclocal-1.10 installed but aclocal-1.6
is chosen. Shouln't it be something like
for am in automake-1.10 automake-1.9 automake-1.8 \
automake-1.7 automake-$AM_NEEDED automake$AM_NEEDED \
automake ; do
instead?
Sebastian
Ralph Giles wrote:>> - EXTRA_DIST lists seven .in files though they get auto-added >> as there appear in AC_OUTPUT. COPYING is also auto-added. > > Which version of automake did this start happenning? :)PS: I checked with 1.10.1, I can say for sure that 1.10 already did that. Sebastian