Vorbis dev - Feb 2006 - vcedit/vorbiscomment heterogeneous streams

Hi,

The following changes allow vorbiscomment to read and edit the
tags for the first occuring vorbis stream in a muxed (and
chained) Ogg bitstream, while retaining the renormalisation.

I've tested it on a number of combinations of muxed and chained
streams, using the write comments from file option for
vorbiscomment to rewrite the comment header and then cmp for
binary differences.  Seems to work so far.

Any comments/corrections?

There's the possibility of testing for other streams (with a
view to Theora/Speex), but I'm sceptical whether they can be
easily handled while retaining the renormalisation.

-- 
imalone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vceditaux.h
Type: text/x-chdr
Size: 221 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20060222/071788b1/vceditaux.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbiscomment.diff
Type: text/x-patch
Size: 15383 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20060222/071788b1/vorbiscomment.bin

On 2/22/06, Ian Malone <ibmalone@gmail.com> wrote:
> Hi,
>
> The following changes allow vorbiscomment to read and edit the
> tags for the first occuring vorbis stream in a muxed (and
> chained) Ogg bitstream, while retaining the renormalisation.
>
I realised this morning that I forgot to test whether a retaggable stream
was found in the bos read. The return values of the buffer chain pushes
also need to be tested (trivial, but needed to prevent silently mangling
streams if buffer memory runs out).  Will probably look at that this
evening.

--
imalone

Ian Malone wrote:
> Hi,
> 
> The following changes allow vorbiscomment to read and edit the
> tags for the first occuring vorbis stream in a muxed (and
> chained) Ogg bitstream, while retaining the renormalisation.
> 
> I've tested it on a number of combinations of muxed and chained
> streams, using the write comments from file option for
> vorbiscomment to rewrite the comment header and then cmp for
> binary differences.  Seems to work so far.
> 
As I mentionned in the other email, the previous set of patches
didn't include some error checks[1].  This patch to be applied on
top fixes that (don't want to clog mailboxes with two copies of
the first set).  I'll put the combined set up on
<www.srcf.ucam.org/~ibm21/omd_links/> later.

[1]  Failure to check whether buffer pushes succeeded, failure
    to check new link insertion, failure to check whether a
    supported stream was found.
-- 
imalone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbiscomment.imalone_1-2.diff
Type: text/x-patch
Size: 5005 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20060225/40adae29/vorbiscomment.imalone_1-2.bin