Vorbis dev - Sep 2004 - MSVC files include vorbisenc in the vorbis dynamic library

Hi,

A short mail to let you know that the MSVC project files aren't OK 
compared to the Makefiles.
Indeed they include the vorbisenc part (vorbisenc.c file, and 
vorbis_encode_* function names in the .def file) inside the vorbis 
library, and they also point to a non-existant file (bitbuffer.h)

Here is a patch to fix this, in case you are interested (patch made on 
the win32 directory using TortoiseSVN) :

Index: win32/vorbis_dynamic.dsp
==================================================================---
win32/vorbis_dynamic.dsp    (revision 7777)
+++ win32/vorbis_dynamic.dsp    (working copy)
@@ -170,10 +170,6 @@
 # End Source File
 # Begin Source File
 
-SOURCE=..\lib\vorbisenc.c
-# End Source File
-# Begin Source File
-
 SOURCE=..\lib\window.c
 # End Source File
 # End Group
@@ -186,10 +182,6 @@
 # End Source File
 # Begin Source File
 
-SOURCE=..\lib\bitbuffer.h
-# End Source File
-# Begin Source File
-
 SOURCE=..\lib\bitrate.h
 # End Source File
 # Begin Source File
Index: win32/vorbis.def
==================================================================---
win32/vorbis.def    (revision 7777)
+++ win32/vorbis.def    (working copy)
@@ -47,10 +47,4 @@
 vorbis_synthesis_halfrate_p
 ;
 vorbis_window
-_analysis_output_always
-vorbis_encode_init
-vorbis_encode_setup_managed
-vorbis_encode_setup_vbr
-vorbis_encode_init_vbr
-vorbis_encode_setup_init
-vorbis_encode_ctl
\ No newline at end of file
+_analysis_output_always
\ No newline at end of file


Best regards
Cyrius

----- Original Message ----- 
From: "Cyrius" <suiryc@yahoo.com>
To: <vorbis-dev@xiph.org>
Sent: Sunday, September 19, 2004 1:33 AM
Subject: [Vorbis-dev] MSVC files include vorbisenc in the vorbis 
dynamiclibrary

> Hi,
>
> A short mail to let you know that the MSVC project files aren't OK 
> compared to the Makefiles.
> Indeed they include the vorbisenc part (vorbisenc.c file, and 
> vorbis_encode_* function names in the .def file) inside the vorbis 
> library, and they also point to a non-existant file (bitbuffer.h)
>
While i agree it would be good to select if you want encoding support or 
not... i don't see why the library shouldn't include both the encode and
decode functions ? All the other libraries (speex, theora, flac) include 
both encode and decode... and libogg contains both mux and demux functions.

Zen.