Hello, the appended Patch makes vorbis work on KDE 3.0.(again) A seek on a closed stream segfault vorbis, unfortunately this situation happens in the KDE Multimedia player very frequently (threads), thus vorbis does not work with KDE 3.0. The bug is that the goto seek_error calls in ov_pcm_seek_page do not set the return value in the error case. Monty, can you apply this? The bug was introduced by the new search algo: /* new search algorithm by HB (Nicholas Vinen) */ regards, Martin RCS file: /usr/local/cvsroot/vorbis/lib/vorbisfile.c,v retrieving revision 1.59 diff -u -r1.59 vorbisfile.c --- lib/vorbisfile.c 2002/03/07 03:41:03 1.59 +++ lib/vorbisfile.c 2002/03/18 09:36:43 @@ -1175,6 +1175,7 @@ /* dump machine so we're in a known state */ vf->pcm_offset=-1; _decode_clear(vf); + ret=OV_ENOSEEK; return ret; } <p>--- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
At 10:45 AM 3/18/02 +0100, you wrote:> > >Hello, > >the appended Patch makes vorbis work on KDE 3.0.(again) > >A seek on a closed stream segfault vorbis, unfortunately >this situation happens in the KDE Multimedia player >very frequently (threads), thus vorbis does not work with KDE 3.0. > >The bug is that the goto seek_error calls in ov_pcm_seek_page >do not set the return value in the error case. > >Monty, can you apply this?Though there may be (it looks like there is) a bug here, this fix is definately incorrect (you've changed it to return the wrong error code - which in the buggy cases is better than no error code, admittedly). I'll take a closer look and see if I can fix it properly. Your reasoning doesn't entirely make sense, in that the goto seek_error calls are never reached if the stream has been closed (as you say it has been in this case). Sounds like there's a nasty bug in your multimedia player as well. Can you file this bug at http://bugs.xiph.org (bugzilla), this'll ensure it gets fixed before the next release, otherwise reports like this often get lost. Michael <p>--- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
>------- Additional Comments From Michael Smith 2002-03-28 23:56 ------- >Fixed in CVS now. Can you please check that it works as intended?Works now. Thanks. Martin <p>--- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.