Here are some minor things I noticed when updating the vorbis module
for GoldWave:
Bitwise.c, line 175 and 207
Warning: Negative unsigned value
ret=-1UL;
Info.c, line 385
Warning: Unreachable code
break;
vorbisfile.c, line 1407
Warning: Call to function with no prototype
int host_endian = host_is_big_endian();
fix: add 'void' to line 1339:
static int host_is_big_endian( void ) {
time0.c, line 36, runtime error
Access overrun (reported by Borland CodeGuard)
return "";
One not so minor thing:
vorbis_encode_init() does not seem to be working correctly. No matter
what bitrates are specified, the output file always seems to be 200+kbps.
vorbis_encode_init_vbr() creates smaller files (though the HTML API
document mentions bitrate settings). However, there is currently no
ov_quality() function to determine the current quality setting to use
if someone opens, edits, then resaves a vorbis file. Perhaps the vbr
quality to/from bitrate functions could be part of the API.
Chris
http://www.goldwave.com
<p>--- >8 ----
List archives: http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body. No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.
> vorbis_encode_init() does not seem to be working correctly. No matter > what bitrates are specified, the output file always seems to be 200+kbps.A few posts here have already gone over the new (and minimal) api changes required for RC3. We're sorry we broke them, but it's only slight, and this should be final. Check encoder_example.c. Or encode.c in oggenc. jack. --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Chris Craig wrote:> > Here are some minor things I noticed when updating the vorbis module > for GoldWave: > > Bitwise.c, line 175 and 207The file is called bitwise.c (no capital B).> Warning: Negative unsigned value > ret=-1UL;The constant is _not_ negative (-1 isn't part of the number token). Yes, returning -1 as an unsigned is dirty.> > Info.c, line 385 > Warning: Unreachable code > break;Harmless. Some other compilers warn _without_ it. Removing it is nicer, yes, imho.> > vorbisfile.c, line 1407 > Warning: Call to function with no prototype > int host_endian = host_is_big_endian(); > fix: add 'void' to line 1339: > static int host_is_big_endian( void ) {That's a bug, yes.> > time0.c, line 36, runtime error > Access overrun (reported by Borland CodeGuard) > return "";What's wrong with this? <p>Segher <p>--- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Segher Boessenkool wrote:> The file is called bitwise.c (no capital B).Sorry, force of habit when typing e-mail.> The constant is _not_ negative (-1 isn't part of the number > token). Yes, returning -1 as an unsigned is dirty.Borland reports it as a warning. Could -1L be used instead since a signed long is being returned, or is that a cross-platform problem?> Some other compilers warn _without_ it.I did not know that.> What's wrong with this?Borland CodeGuard reports an access overrun of 4 bytes where it claims only 3 bytes exist. :-) I just wanted to make sure that returning a pointer to an empty string is correct. I take it from Jack Moffitt's reply that no one is having trouble with the vorbis_encode_init() function? For example: vorbis_encode_init(&vi, 2, 44100, 96000, 96000, 96000); always gives 200+kbps files, regardless what bitrate is used in what parameter (max, nominal, or min), even in combination with -1 or 0. Also, vorbis_encode_init_vbr.html needs some editing since it mentions bitrates (probably copied from the other init doc). Chris Craig http://www.goldwave.com <p>--- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.