Another one at block.c:176:
---
Title: We The People
Artist: DJ Lithium Presents
Bitstream is 2 channel, 44100Hz
Time: 58:29.07, Bitrate: 100.1
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1024 (LWP 27207)]
_vds_shared_init (v=0xbffff73c, vi=0x4024efe0, encp=0) at block.c:176
176 b->modebits=ilog2(ci->modes);
(gdb) bt
#0 _vds_shared_init (v=0xbffff73c, vi=0x4024efe0, encp=0) at block.c:176
#1 0x40040eb6 in vorbis_synthesis_init (v=0xbffff73c, vi=0x4024efe0) at
block.c:621
#2 0x40033fa3 in _make_decode_ready (vf=0xbffff560) at vorbisfile.c:343
#3 0x4003441c in _process_packet (vf=0xbffff560, readp=1) at vorbisfile.c:547
#4 0x4003640e in ov_read (vf=0xbffff560, buffer=0x804d060
"GÐøÏMÐýÏRÐ",
length=4096, bigendianp=0, word=2, sgned=1, bitstream=0xbfffe53c)
at vorbisfile.c:1486
#5 0x0804a0e1 in play_file (opt {read_file = 0xbffffa6d
"http://www.djlithium.com:8064/djlithium.ogg",
shuffle = 0 '\000', verbose = 1, quiet = 0, seekpos = 19.24444580078125,
instream = 0x40333e94, outdevices = 0x4024cfec, buffer_size = 0, rate
-1073743656, channels = 1073797552, delay = 1}) at ogg123.c:477
#6 0x0804994b in main (argc=3, argv=0xbffff560) at ogg123.c:250
#7 0x400bb177 in __libc_start_main (main=0x8049570 <main>, argc=3,
ubp_av=0xbffff934, init=0x8048f9c <_init>, fini=0x804adc0 <_fini>,
rtld_fini=0x4000e184 <_dl_fini>, stack_end=0xbffff92c) at
../sysdeps/generic/libc-start.c:129
---
--
Ignacio Vazquez-Abrams <ignacio@openservices.net>
--- >8 ----
List archives: http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body. No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.
Could somebody take a look at lib/vorbisfile.c:541 and please tell me why the return value of _fetch_headers() isn't checked? I believe that that is the source of the core dumps. -- Ignacio Vazquez-Abrams <ignacio@openservices.net> --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Wed, Sep 12, 2001 at 03:34:01AM -0400, Ignacio Vazquez-Abrams wrote:> Another one at block.c:176:These look consistent. I'm exploring now (and yes, it could be a bad header fetch that wasn't erring out properly as you noted earlier. But that should kill things for *everyone*). Monty --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Wed, Sep 12, 2001 at 03:34:01AM -0400, Ignacio Vazquez-Abrams wrote:> Another one at block.c:176: > > --- > Title: We The People > Artist: DJ Lithium Presents > > Bitstream is 2 channel, 44100Hz > Time: 58:29.07, Bitrate: 100.1 > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 1024 (LWP 27207)] > _vds_shared_init (v=0xbffff73c, vi=0x4024efe0, encp=0) at block.c:176 > 176 b->modebits=ilog2(ci->modes);could you let me know what the values of b and ci are? Monty --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Wed, Sep 12, 2001 at 03:34:01AM -0400, Ignacio Vazquez-Abrams wrote:> Another one at block.c:176: > > --- > Title: We The People > Artist: DJ Lithium Presents > > Bitstream is 2 channel, 44100Hz > Time: 58:29.07, Bitrate: 100.1 > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 1024 (LWP 27207)] > _vds_shared_init (v=0xbffff73c, vi=0x4024efe0, encp=0) at block.c:176 > 176 b->modebits=ilog2(ci->modes); > (gdb) bt > #0 _vds_shared_init (v=0xbffff73c, vi=0x4024efe0, encp=0) at block.c:176 > #1 0x40040eb6 in vorbis_synthesis_init (v=0xbffff73c, vi=0x4024efe0) at > block.c:621 > #2 0x40033fa3 in _make_decode_ready (vf=0xbffff560) at vorbisfile.c:343 > #3 0x4003441c in _process_packet (vf=0xbffff560, readp=1) at vorbisfile.c:547 > #4 0x4003640e in ov_read (vf=0xbffff560, buffer=0x804d060 "GÐøÏMÐýÏRÐ", > length=4096, bigendianp=0, word=2, sgned=1, bitstream=0xbfffe53c) > at vorbisfile.c:1486 > #5 0x0804a0e1 in play_file (opt> {read_file = 0xbffffa6d "http://www.djlithium.com:8064/djlithium.ogg", > shuffle = 0 '\000', verbose = 1, quiet = 0, seekpos = 19.24444580078125, > instream = 0x40333e94, outdevices = 0x4024cfec, buffer_size = 0, rate > -1073743656, channels = 1073797552, delay = 1}) at ogg123.c:477 > #6 0x0804994b in main (argc=3, argv=0xbffff560) at ogg123.c:250 > #7 0x400bb177 in __libc_start_main (main=0x8049570 <main>, argc=3, > ubp_av=0xbffff934, init=0x8048f9c <_init>, fini=0x804adc0 <_fini>, > rtld_fini=0x4000e184 <_dl_fini>, stack_end=0xbffff92c) at > ../sysdeps/generic/libc-start.c:129 > --- > > -- > Ignacio Vazquez-Abrams <ignacio@openservices.net> > > > > --- >8 ---- > List archives: http://www.xiph.org/archives/ > Ogg project homepage: http://www.xiph.org/ogg/ > To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' > containing only the word 'unsubscribe' in the body. No subject is needed. > Unsubscribe messages sent to the list will be ignored/filtered. >--- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
OK, I built one with electric fence and full symbols myself (in addition to adding the _fetch_headers return val check. Looking actively for this problem using the djlithium stream. Monty --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
OK, I found the bugs and I'm committing fixes now. However, the original trigger for this bug is that whatever is generating the djlithium stream is occasionally sticking garbage between pages. libvorbisfile was apparently handling that happily everywhere except between header pages. In the djlithium stream segment Ignacio sent me, there were two garbage bytes btween pages two and three. What's being used to make this stream? That bug should be fixed. (I'm hardening vorbisfile against the problem so that it's more tolerant of garbage. The streaming software should still be fixed). Monty --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.