Vorbis dev - May 2001 - fix for oggdrop disappearing window

Hi,

I don't know if this problem has been looked at yet.  The latest version of
oggdrop I found was at
http://www.vorbis.com/files/beta4/windows/oggdrop-1.0beta4.zip.  If you whip
the window quickly from right to left, the client mouse coordinate in
WM_MOUSEMOVE *can* be negative and so the LOWORD and HIWORD macros will cast
the mouse coordinates to insanely high 64K-ish values.  Then the
SetWindowPos moves the window into lala land never to be seen again.  I
don't think windows should ever give you a neg client coordinate, but it
does (maybe it's a win2k thing).

The attached patch just uses LOSHORT and HISHORT macros (signed versions of
the LO/HI WORD macros) instead.  Let me know if it makes sense.

- btw, to reproduce the bug, grab the window and whip around like mad until
it disappears.

Thanks,
Anish Dave
Comp Sci/Soft Eng
Univ of Waterloo (recent grad!)
adave@undergrad.math.uwaterloo.ca


<HR NOSHADE>
<UL>
<LI>application/octet-stream attachment: main.diff
</UL>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: main.diff
Type: application/octet-stream
Size: 770 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010505/ad792607/main-0001.obj

----- Original Message -----
From: "Anish Dave" <adave@undergrad.math.uwaterloo.ca>
To: "Vorbis Dev" <vorbis-dev@xiph.org>
Sent: Sunday, May 06, 2001 5:48 AM
Subject: [vorbis-dev] fix for oggdrop disappearing window
> Hi,
>
> I don't know if this problem has been looked at yet.  The latest
version
of
> oggdrop I found was at
> http://www.vorbis.com/files/beta4/windows/oggdrop-1.0beta4.zip.  If you
whip
> the window quickly from right to left, the client mouse coordinate in
> WM_MOUSEMOVE *can* be negative and so the LOWORD and HIWORD macros will
cast
> the mouse coordinates to insanely high 64K-ish values.  Then the
> SetWindowPos moves the window into lala land never to be seen again.  I
> don't think windows should ever give you a neg client coordinate, but
it
> does (maybe it's a win2k thing).
>From MSDN:
> Value of the low-order word of lParam. Specifies the x-coordinate of the
cursor. The coordinate is relative to the upper-left corner of the client
area.

So sure, negative is possible.
I'll also patch my version.
Would it maybe be possible to post a link to my version on the official
Vorbis page, clearly marking this as an unofficial version, so users can try
it?
>
> The attached patch just uses LOSHORT and HISHORT macros (signed versions
of
> the LO/HI WORD macros) instead.  Let me know if it makes sense.
>
> - btw, to reproduce the bug, grab the window and whip around like mad
until
> it disappears.
>
> Thanks,
> Anish Dave
> Comp Sci/Soft Eng
> Univ of Waterloo (recent grad!)
> adave@undergrad.math.uwaterloo.ca
>
--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.