Vorbis dev - Jan 2001 - Makefile.am patch

Since vorbiscomment is being resurrected in a new form, can someone please
fix the vorbis-tools/vorbiscomment/Makefile.am?

There's two things wrong:

1. Using _LDFLAGS doesn't allow the user to specify their own LDFLAGS.
   _LDADD or _LIBS should be used instead.

2. The order of libraries is wrong such that it won't link properly when
   compiled statically.

Here's a trivial patch to fix that one line (from "cvs diff -c"):

Index: Makefile.am
==================================================================RCS file:
/usr/local/cvsroot/vorbis-tools/vorbiscomment/Makefile.am,v
retrieving revision 1.6
diff -c -r1.6 Makefile.am
*** Makefile.am	2001/01/19 11:39:23	1.6
--- Makefile.am	2001/01/20 13:52:55
***************
*** 6,12 ****

  INCLUDES = @OGG_CFLAGS@ @VORBIS_CFLAGS@

! vorbiscomment_LDFLAGS = @OGG_LIBS@ @VORBIS_LIBS@
  vorbiscomment_SOURCES = vcedit.c vcedit.h vcomment.c

  debug:
--- 6,12 ----

  INCLUDES = @OGG_CFLAGS@ @VORBIS_CFLAGS@

! vorbiscomment_LDADD = @VORBIS_LIBS@ @OGG_LIBS@
  vorbiscomment_SOURCES = vcedit.c vcedit.h vcomment.c

  debug:

{+} Jeff Squyres
{+} squyres@cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

BTW, here's 4 patches to fix the Makefile.am/no-dependencies problem (one
for ao, ogg, vorbis, and vorbis-tools).  :-)

-----

After applying these patches, I could compile with the sun Forte
compilers.  Got some minor warnings in the vorbis-tools packages (this is
all at the CVS HEAD):

1. Some minor type warnings in oggenc/utf8.c.  It seemed to be just
(char*) vs. (unsigned char*) issues, and I'm assuming that there was a
reason that (unsigned char*) was used.  So I added casts, and they seemed
to do the right things.  Someone please check...  Patch attached:
oggenc.patch.

2. Some type warnings in ogg123; this one is new to me:

"buffer.c", line 64: warning: assignment type mismatch:
        volatile pointer to struct chunk_s {long len, array[4096] of char
data} "=" pointer to volatile struct chunk_s {long len, array[4096] of
char data}

3. More (char*) vs. (unsigned char*) issues in vcut.  Simlar to #1,
someone please check, but suggested patch attached (vcut.diff).

Thanks.

{+} Jeff Squyres
{+} squyres@cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"


<HR NOSHADE>
<UL>
<LI>TEXT/PLAIN attachment: ao.diff
</UL>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ao.diff
Type: application/octet-stream
Size: 6678 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010822/47d2d833/ao-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ogg.diff
Type: application/octet-stream
Size: 4018 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010822/47d2d833/ogg-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis.diff
Type: application/octet-stream
Size: 9703 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010822/47d2d833/vorbis-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools.diff
Type: application/octet-stream
Size: 4192 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010822/47d2d833/vorbis-tools-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oggenc.diff
Type: application/octet-stream
Size: 849 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010822/47d2d833/oggenc-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vcut.diff
Type: application/octet-stream
Size: 1236 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010822/47d2d833/vcut-0001.obj