Rather than using libtool to build its sets, the ao.m4 in beta3 is hard coding '-ldl': AO_LIBS="$AO_LIBS -lao -ldl" Not all systems have a dl library. For now, I can obviously just remove it and keep working on stuff, but what would be a suitable patch that would get accepted to be committed? Should I just check the current build target and set AO_LIBS differently on my host? -tim --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
At 05:35 PM 11/18/00 -0800, you wrote:> > > Rather than using libtool to build its sets, the ao.m4 in beta3 is hardcoding '-ldl':> > AO_LIBS="$AO_LIBS -lao -ldl" > > Not all systems have a dl library. For now, I can obviously just removeit and keep working on stuff, but what would be a suitable patch that would get accepted to be committed? Should I just check the current build target and set AO_LIBS differently on my host? libao now needs libdl. A patch would be good, but would also have to change the code in some fairly significant ways. Well, unless there's some platform without libdl, but WITH all the libdl functions in a different libraries. I don't know of any such platform. libao isn't portable (due solely to libdl use), and the only thing that uses it is ogg123 (which is extremely unportable), so it's probably not worth fixing - someone is apparently rewriting/replacing ogg123. The main problem is that vorbis-tools requires libao at the moment - and libao doesn't neccesarily build on everything (we fixed it yesterday for solaris, but ogg123 is still broken there). Probably should change some stuff in vorbis-tools configure so that if ao is missing, it just doesn't build ogg123. Michael --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
>libao now needs libdl. A patch would be good, but would also have to change >the code in some fairly significant ways. Well, unless there's some >platform without libdl, but WITH all the libdl functions in a different >libraries. I don't know of any such platform.Well, Darwin and Mac OS X don't have libdl, but there are emulation sources that can be obtained from the Darwin repository and added to libao (which is was I was currently doing). Maybe instead, I should take to the dlopen.c and dlfcn.h and build a /usr/local/lib/libdl.dylib and /usr/local/include/dlfcn.h and then Vorbis could build as usual. This would be lame, though, since Vorbis would have yet another dependancy (although this is mitigated by the fact that this would probably make other GNU software work better). I guess I'll go down this route rather than including it in libao, which would probably be annoying to those people not on Darwin / Mac OS X. -tim --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
>Given that the >chances of ogg123 working on OS X are slim anyway (it doesn't even build on >solaris, which is far closer to linux than OS X is), you might not want to >bother with this at all.I had it working before, but none of my patches (or the other guy that was working on this) got committed. Unless something major has changed, getting ogg123 to work shouldn't be that hard. The 'hard' part is getting libao to deal with the CoreAudio framework. The really hard part is getting libtool and friends to work right on Darwin/Mac OS X, but this should pay off in the future :) Hopefully I'll have some patches in the not too distant future. -tim --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
In my opinion, using dlopen in libao was a bad choice in the first place. Loadable modules make sense in a few cases: - When you don't want to release source to the code doing the loading but still want to allow users to extend it. Obviously not a concern here. - When there are zillions of potential plugins (image filters, for example). Obviously not a concern here. - When it is too difficult/time consuming/costly for the average developer to build the system that would do the loading. Also obviously not a concern here. libao is a _tiny_ piece of code that really does very little and is just being needlessly complicated by the dlopen() usage. If I had to guess, I'd say that someone was interested in learning dlopen() and choose to do it here, but I think this is a bad design decision given the criteria above. This ended up making the code less portable with out much benefit that I see. -tim --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.