Vorbis dev - Oct 2000 - ogg123 does not stop at the end of the file

MoiN

ogg123 does not exit after playing a file but starts to eat all
available cpu time, trying to read past the end of the file.
Please apply the following patch to ogg123.c in vorbis-tools:

--- vorbis-tools/ogg123/ogg123.c.orig	Thu Oct 26 22:37:05 2000
+++ vorbis-tools/ogg123/ogg123.c	Thu Oct 26 22:37:29 2000
@@ -461,9 +461,9 @@
                 while (!eos) {
                         old_section = current_section;
                         switch ((ret = ov_read (&vf, convbuffer, sizeof
(convbuffer), is_big_endian, 2, 1, &current_section))) {
                         case 0: /* End of file */
-				eof = 1;
+				eof = eos = 1;
                                 break;
                         case -1: /* Stream error */
                                 fprintf(stderr, "W: Stream error\n");
                                 break;

    Ingo

-- 
<PRE>      _
          ( )  ASCII Ribbon Campaign
          /~\  Against HTML Mail
</PRE>   '   `

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

> ogg123 does not exit after playing a file but starts to eat all
> available cpu time, trying to read past the end of the file.
> Please apply the following patch to ogg123.c in vorbis-tools:
It is also the case that vorbisfile now returns more complex error
codes than '-1'.  If ogg123 wants to trap an error, it has to be looking
for <0, not -1.

(the quoted code doesn't break, it just misses the error returns)

The error codes are documented in doc/vorbis-errors.txt on branch_beta3.

Monty

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.