Vorbis dev - Aug 2000 - vorbis' configure

It seems that the configure script in CVS does not check the CFLAGS
environment variable at all.  Indeed, on line 121 of configure.in, CFLAGS
is explicitly set to be blank.

Is this done for a reason?  I see that several sets of CFLAGS are passed
into the Makefiles by configure based upon specific architecture/compiler
combinations -- perhaps this is the reason...?

I ask because users may wish to pass in their own CFLAGS (for compiler/OS
combinations that are not specified, or need to pass additional CFLAGS for
thread-safety, etc., etc.).  For example, I needed to manually add
"-mt"
to the Makefiles to get thread-safe generation muckety muck from the
Solaris workshop compilers.

Can the 'CFLAGS=""' line be removed?  I don't think it
will break
anything, and it should allow greater flexibility to the user.

Thanks.

{+} Jeff Squyres
{+} squyres@cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/

> 
> Can the 'CFLAGS=""' line be removed?  I don't think
it will break
> anything, and it should allow greater flexibility to the user.
> 
> Thanks.
> 
> {+} Jeff Squyres
> {+} squyres@cse.nd.edu
> {+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
> {+} "I came to ND for 4 years and ended up staying for a decade"
> 
While you're at it, perhaps make all the config stuff apparent for newbies
like me?  I wouldn't mind all the configure options
being visible when I type ./configure --help in the top directory.
I might be leaving out some but, I wouldn't
mind being overly helpful.  Perhaps

# [ejk] hack
AC_ARG_WITH(cflags,
        [  --with-cflags[=ARG]     add compilation flags to all targets
[\"\"]],
        [cflags="$withval"],
        [cflags=""])
CFLAGS="$CFLAGS $cflags"
AC_ARG_ENABLE(oss,
        [  --disable-oss           (libao) disable OSS support],
        ,enable_oss=yes)
AC_ARG_ENABLE(irix,
        [  --disable-irix          (libao) disable irix support],
        ,enable_irix=yes)
AC_ARG_ENABLE(solaris,
        [  --disable-solaris       (libao) disable solaris support],
        ,enable_solaris=yes)
AC_ARG_ENABLE(alsa,
        [  --disable-alsa          (libao) disable alsa support],
        ,enable_alsa=yes)
AC_ARG_ENABLE(esd,
        [  --disable-esd           (libao) disable esd support],
        ,enable_esd=yes)
AC_ARG_ENABLE(default-output,
        [  --disable-default-output (libao) disable default output],
        ,enable_default_output=def)
# [ejk] hack

(Near the top of the main configure.in)

Now I can do something like 
 ./configure --with-cflags="-mt -I/home/kruus -I/home/kruus/v"
-disable-oss
and it seems to propagate to the Makefiles correctly

Of course there may be a better way!
Erik.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/