Monty
2000-Jul-19 12:15 UTC
[vorbis-dev] possible bug in _f0_fit_clear (BOUNCE vorbis-dev@xiph.org: Non-member submission from ["Dimitry Andric" <dimit (fwd)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2000-07-19 at 11:06 Monty wrote:>I'll have to give things a look later/tomorrow to make sure nothing >'bad' (tm) crept in. I know, for example, that the books involved >are likely not exactly what I wanted to be using, but should be OK. >Specifically, the lsp12 and 30 codebooks are gigantic and the mode >description in modes.h is more like a 160 kbps than a 128kbps mode.I was already thinking, why is my encoder executable suddenly > 1 meg ?? ;-) Anyway, Monty, would you please consider moving the codebooks from header files to .c files somewhere in the future (if at all possible of course)? Since this would save a lot of redundancy when several applications use the same vorbis (shared) libraries. The tables then only need to appear once on any system, instead of in every executable. Cheers, - -- Dimitry Andric <dimitry@andric.com> PGP key: http://andric.com/dim.asc KeyID: 4096/1024-0x2E2096A3 Fingerprint: 7AB4 62D2 CE35 FC6D 4239 4FCD B05E A30A 2E20 96A3 -----BEGIN PGP SIGNATURE----- Version: Encrypted with PGP Plugin for Calypso Comment: http://www.gn.apc.org/duncan/stoa_cover.htm iQA/AwUBOXXigLBeowouIJajEQJNGgCfQ292JGMXlvYtae+06EHBbDk90ykAoMEc A69WU1IAb0VsfkS6dmJ5WeAC =3D/ZDl -----END PGP SIGNATURE----- --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/
Monty
2000-Jul-19 12:19 UTC
[vorbis-dev] possible bug in _f0_fit_clear (BOUNCE vorbis-dev@xiph.org: Non-member submission from ["Dimitry Andric" <dimit (fwd)
> Anyway, Monty, would you please consider moving the codebooks from > header files to .c files somewhere in the future (if at all possible > of course)? Since this would save a lot of redundancy when several > applications use the same vorbis (shared) libraries.Only the encoder uses those tables, and the tables are likely to change more often than the shared lib under them. Not including them in the shared lib also substantially slims down *de*coders (the encoder size, in fact, is mostly these tables, not code). However, the whole .vqh thing is a hack that's nearing the end of its life. Before 1.0 final, I expect to replace them with packed binary files (which both eliminates a potential source of library revision incompatability as well as saving more space). Monty --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/