Vorbis dev - Jun 2000 - vorbis-tools/Makefile.in glitch...

I'm updating my vorbis rpm spec file, and when I try to do "make -C
vorbis-tools ogg123", due to rpm's build environment, I get lots of:

gcc  ogg123.o -o ogg123 -lm ../lib/libvorbis.a ../lib/vorbisfile.a
../lib/vorbisfile.a(vorbisfile.o): In function `_get_prev_page':
vorbisfile.o(.text+0x54): undefined reference to `ogg_sync_reset'
vorbisfile.o(.text+0xa9): undefined reference to `ogg_sync_pageseek'
vorbisfile.o(.text+0xd2): undefined reference to `ogg_sync_buffer'
...

This is obviously because libvorbis comes before vorbisfile on the command
line ;).  It really seems like we should be doing "-L../lib -lvorbis"
instead of ../lib/libvorbis.a though, and that would fix the problem.
Anybody have any objections to that, or any other suggestion of a propper
way to handle this?

If thats the right way, I'll just put it into CVS myself.

 -- Peter, taking a moment away from his day job...

"What is a magician but a practicing theorist?"
                -- Kenobi

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/

On Tue, Jun 27, 2000 at 10:50:31AM -0400, Peter Jones
wrote:
> I'm updating my vorbis rpm spec file, and when I try to do "make
-C
> vorbis-tools ogg123", due to rpm's build environment, I get lots
of:
> 
> gcc  ogg123.o -o ogg123 -lm ../lib/libvorbis.a ../lib/vorbisfile.a
> ../lib/vorbisfile.a(vorbisfile.o): In function `_get_prev_page':
> vorbisfile.o(.text+0x54): undefined reference to `ogg_sync_reset'
> vorbisfile.o(.text+0xa9): undefined reference to `ogg_sync_pageseek'
> vorbisfile.o(.text+0xd2): undefined reference to `ogg_sync_buffer'
> ...
> 
> This is obviously because libvorbis comes before vorbisfile on the command
> line ;).  It really seems like we should be doing "-L../lib
-lvorbis"
> instead of ../lib/libvorbis.a though, and that would fix the problem.
> Anybody have any objections to that, or any other suggestion of a propper
> way to handle this?
> 
> If thats the right way, I'll just put it into CVS myself.
I have already commited a fixed Makefile.in, but your way is IMO, more
correct if it works :)

                       Michael Beattie (mickyb@es.co.nz)

 -----------------------------------------------------------------------------
                 Documentation - The worst part of programming.
 -----------------------------------------------------------------------------
                Debian GNU/Linux....  Ooohh You are missing out!


<HR NOSHADE>
<UL>
<LI>application/pgp-signature attachment: stored
</UL>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: part
Type: application/octet-stream
Size: 412 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20000629/1595e7b3/part-0001.obj