Virtualization - Jul 2023 - [PATCH 0/2] vdpa: Enable strict validation for netlink ops

On Wed, 2023-07-26 at 14:36 -0400, Michael S. Tsirkin
wrote:
> On Wed, Jul 26, 2023 at 09:30:48PM +0300, Dragos Tatulea wrote:
> > The original patch from Lin Ma enables the vdpa driver to use
validation
> > netlink ops.
> > 
> > The second patch simply disables the validation skip which is no
longer
> > neccesary. Patchset started of from this discussion [0].
> > 
> > [0]
> >
https://lore.kernel.org/virtualization/20230726074710-mutt-send-email-mst at
kernel.org/T/#t
> 
> Cc stable with at least 1/2 ?
> 
Sent a v2 with stable in cc. But looks like 1/2 breaks the "fix one thing
only"
rule due to the many Fixes tags I guess...
> > Dragos Tatulea (1):
> > ? vdpa: Enable strict validation for netlinks ops
> > 
> > Lin Ma (1):
> > ? vdpa: Complement vdpa_nl_policy for nlattr length check
> > 
> > ?drivers/vdpa/vdpa.c | 9 +++------
> > ?1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > -- 
> > 2.41.0
>

On Wed, 2023-07-26 at 20:56 +0200, Dragos Tatulea wrote:
> On Wed, 2023-07-26 at 14:36 -0400, Michael S. Tsirkin wrote:
> > On Wed, Jul 26, 2023 at 09:30:48PM +0300, Dragos Tatulea wrote:
> > > The original patch from Lin Ma enables the vdpa driver to use
validation
> > > netlink ops.
> > > 
> > > The second patch simply disables the validation skip which is no
longer
> > > neccesary. Patchset started of from this discussion [0].
> > > 
> > > [0]
> > >
https://lore.kernel.org/virtualization/20230726074710-mutt-send-email-mst at
kernel.org/T/#t
> > 
> > Cc stable with at least 1/2 ?
> > 
> Sent a v2 with stable in cc. But looks like 1/2 breaks the "fix one
thing
> only"
> rule due to the many Fixes tags I guess...
> 
Or my lack of understanding: I only now realize that "Cc: stable" is a
tag in
the patch. My bad. Will re-send.
> > > Dragos Tatulea (1):
> > > ? vdpa: Enable strict validation for netlinks ops
> > > 
> > > Lin Ma (1):
> > > ? vdpa: Complement vdpa_nl_policy for nlattr length check
> > > 
> > > ?drivers/vdpa/vdpa.c | 9 +++------
> > > ?1 file changed, 3 insertions(+), 6 deletions(-)
> > > 
> > > -- 
> > > 2.41.0
> > 
>

On Wed, Jul 26, 2023 at 06:56:24PM +0000, Dragos Tatulea
wrote:
> On Wed, 2023-07-26 at 14:36 -0400, Michael S. Tsirkin wrote:
> > On Wed, Jul 26, 2023 at 09:30:48PM +0300, Dragos Tatulea wrote:
> > > The original patch from Lin Ma enables the vdpa driver to use
validation
> > > netlink ops.
> > > 
> > > The second patch simply disables the validation skip which is no
longer
> > > neccesary. Patchset started of from this discussion [0].
> > > 
> > > [0]
> > >
https://lore.kernel.org/virtualization/20230726074710-mutt-send-email-mst at
kernel.org/T/#t
> > 
> > Cc stable with at least 1/2 ?
> > 
> Sent a v2 with stable in cc. But looks like 1/2 breaks the "fix one
thing only"
> rule due to the many Fixes tags I guess...
you can split it up to 3 patches to simplify backports if you like.


> > > Dragos Tatulea (1):
> > > ? vdpa: Enable strict validation for netlinks ops
> > > 
> > > Lin Ma (1):
> > > ? vdpa: Complement vdpa_nl_policy for nlattr length check
> > > 
> > > ?drivers/vdpa/vdpa.c | 9 +++------
> > > ?1 file changed, 3 insertions(+), 6 deletions(-)
> > > 
> > > -- 
> > > 2.41.0
> > 
>