Christoph Hellwig
2023-May-23 06:03 UTC
[PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped
On Wed, May 17, 2023 at 10:22:41AM +0800, Xuan Zhuo wrote:> virtuque_add() adds parameter premapped.Well, I can see that. But why?
Michael S. Tsirkin
2023-May-23 07:19 UTC
[PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped
On Mon, May 22, 2023 at 11:03:26PM -0700, Christoph Hellwig wrote:> On Wed, May 17, 2023 at 10:22:41AM +0800, Xuan Zhuo wrote: > > virtuque_add() adds parameter premapped. > > Well, I can see that. But why?Assuming it's intentional, it should say something along the lines of "The parameter is unused for now, and all callers just pass false. It will be used by a follow-up patch". It's not a bad way to split patches, this way actual logic in the next patch stands out as opposed to being masked by the code reshuffling following the extra parameter. -- MST
Possibly Parallel Threads
- [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped
- [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped
- [PATCH vhost v9 00/12] virtio core prepares for AF_XDP
- [PATCH vhost 04/10] virtio_ring: split: introduce virtqueue_add_split_premapped()
- [PATCH vhost 08/10] virtio_ring: introduce dma sync api for virtio