Christoph Hellwig
2023-Jan-30 09:21 UTC
[PATCH 09/23] virtio_blk: use bvec_set_virt to initialize special_vec
Use the bvec_set_virt helper to initialize the special_vec. Signed-off-by: Christoph Hellwig <hch at lst.de> --- drivers/block/virtio_blk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 6a77fa91742880..dc6e9b989910b0 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -170,9 +170,7 @@ static int virtblk_setup_discard_write_zeroes_erase(struct request *req, bool un WARN_ON_ONCE(n != segments); - req->special_vec.bv_page = virt_to_page(range); - req->special_vec.bv_offset = offset_in_page(range); - req->special_vec.bv_len = sizeof(*range) * segments; + bvec_set_virt(&req->special_vec, range, sizeof(*range) * segments); req->rq_flags |= RQF_SPECIAL_PAYLOAD; return 0; -- 2.39.0
Michael S. Tsirkin
2023-Jan-30 15:17 UTC
[PATCH 09/23] virtio_blk: use bvec_set_virt to initialize special_vec
On Mon, Jan 30, 2023 at 10:21:43AM +0100, Christoph Hellwig wrote:> Use the bvec_set_virt helper to initialize the special_vec. > > Signed-off-by: Christoph Hellwig <hch at lst.de>Acked-by: Michael S. Tsirkin <mst at redhat.com>> --- > drivers/block/virtio_blk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 6a77fa91742880..dc6e9b989910b0 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -170,9 +170,7 @@ static int virtblk_setup_discard_write_zeroes_erase(struct request *req, bool un > > WARN_ON_ONCE(n != segments); > > - req->special_vec.bv_page = virt_to_page(range); > - req->special_vec.bv_offset = offset_in_page(range); > - req->special_vec.bv_len = sizeof(*range) * segments; > + bvec_set_virt(&req->special_vec, range, sizeof(*range) * segments); > req->rq_flags |= RQF_SPECIAL_PAYLOAD; > > return 0; > -- > 2.39.0