On Wed, Jan 18, 2023 at 12:27:39PM -0800, Bobby Eshleman wrote:> +static int vsock_read_skb(struct sock *sk, skb_read_actor_t read_actor) > +{ > + struct vsock_sock *vsk = vsock_sk(sk); > + > + if (!vsk->transport) > + return -ENODEV; > + > + if (!vsk->transport->read_skb) > + return -EOPNOTSUPP;Can we move these two checks to sockmap update path? It would make vsock_read_skb() faster.> + > + return vsk->transport->read_skb(vsk, read_actor); > +}Essentially can be just this one line. Thanks.