Virtualization - Dec 2022 - [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON

On Tue, Dec 20, 2022 at 5:07 PM Alvaro Karsz <alvaro.karsz at
solid-run.com> wrote:
>
> Add a comment in Kconfig explaining the
> "depends on .. && (HWMON || HWMON=n)" part.
>
> This patch should be applied on top of the following patch:
>
> virtio: vdpa: new SolidNET DPU driver,
> by Alvaro Karsz alvaro.karsz at solid-run.com
>
> Signed-off-by: Alvaro Karsz <alvaro.karsz at solid-run.com>
Acked-by: Jason Wang <jasowang at redhat.com>

Thanks
> ---
>  drivers/vdpa/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 79625c7cc46..7396e92b485 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -89,6 +89,14 @@ config ALIBABA_ENI_VDPA
>   config SNET_VDPA
>         tristate "SolidRun's vDPA driver for SolidNET"
>         depends on PCI_MSI && PCI_IOV && (HWMON || HWMON=n)
> +
> +       # This driver MAY create a HWMON device.
> +       # Depending on (HWMON || HWMON=n) ensures that:
> +       # If HWMON=n the driver can be compiled either as a module or
built-in.
> +       # If HWMON=y the driver can be compiled either as a module or
built-in.
> +       # If HWMON=m the driver is forced to be compiled as a module.
> +       # By doing so, IS_ENABLED can be used instead of IS_REACHABLE
> +
>         help
>           vDPA driver for SolidNET DPU.
>           With this driver, the VirtIO dataplane can be
> --
> 2.32.0
>

Hi Michael,

Is this patch ok with you?
Do you have any comments?