Christoph Hellwig
2022-Dec-21 10:45 UTC
[PATCH v2 1/2] virtio-blk: set req->state to MQ_RQ_COMPLETE after polling I/O is finished
On Wed, Dec 21, 2022 at 12:36:12AM +0900, Suwan Kim wrote:> Driver should set req->state to MQ_RQ_COMPLETE after it finishes to process > req. But virtio-blk doesn't set MQ_RQ_COMPLETE after virtblk_poll() handles > req and req->state still remains MQ_RQ_IN_FLIGHT. Fortunately so far there > is no issue about it because blk_mq_end_request_batch() sets req->state to > MQ_RQ_IDLE. > > In this patch, virblk_poll() calls blk_mq_complete_request_remote() to set > req->state to MQ_RQ_COMPLETE before it adds req to a batch completion list. > So it properly sets req->state after polling I/O is finished. > > Fixes: 4e0400525691 ("virtio-blk: support polling I/O") > Signed-off-by: Suwan Kim <suwan.kim027 at gmail.com>Looks good: Reviewed-by: Christoph Hellwig <hch at lst.de>