> -----Original Message-----
> From: Herbert Xu [mailto:herbert at gondor.apana.org.au]
> Sent: Tuesday, November 22, 2022 5:42 PM
> To: Gonglei (Arei) <arei.gonglei at huawei.com>;
> virtualization at lists.linux-foundation.org; Linux Crypto Mailing List
> <linux-crypto at vger.kernel.org>
> Subject: [PATCH] crypto: virtio - Use helper to set reqsize
>
> The value of reqsize must only be changed through the helper.
>
> Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
>
> diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> index 168195672e2e..b2979be613b8 100644
> --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> @@ -479,6 +479,9 @@ static int virtio_crypto_rsa_init_tfm(struct
> crypto_akcipher *tfm)
> ctx->enginectx.op.prepare_request = NULL;
> ctx->enginectx.op.unprepare_request = NULL;
>
> + akcipher_set_reqsize(tfm,
> + sizeof(struct virtio_crypto_akcipher_request));
> +
> return 0;
> }
>
> @@ -505,7 +508,6 @@ static struct virtio_crypto_akcipher_algo
> virtio_crypto_akcipher_algs[] = {
> .max_size = virtio_crypto_rsa_max_size,
> .init = virtio_crypto_rsa_init_tfm,
> .exit = virtio_crypto_rsa_exit_tfm,
> - .reqsize = sizeof(struct virtio_crypto_akcipher_request),
> .base = {
> .cra_name = "rsa",
> .cra_driver_name = "virtio-crypto-rsa", @@ -528,7
> +530,6 @@ static struct virtio_crypto_akcipher_algo
> virtio_crypto_akcipher_algs[] = {
> .max_size = virtio_crypto_rsa_max_size,
> .init = virtio_crypto_rsa_init_tfm,
> .exit = virtio_crypto_rsa_exit_tfm,
> - .reqsize = sizeof(struct virtio_crypto_akcipher_request),
> .base = {
> .cra_name = "pkcs1pad(rsa,sha1)",
> .cra_driver_name = "virtio-pkcs1-rsa-with-sha1",
> --
Acked-by: Gonglei <arei.gonglei at huawei.com>
Regards,
-Gonglei