Jason Wang
2022-Nov-14 08:55 UTC
[PATCH 3/6] vduse: Add sysfs interface for irq affinity setup
On Mon, Nov 14, 2022 at 4:20 PM Yongji Xie <xieyongji at bytedance.com> wrote:> > On Mon, Nov 14, 2022 at 3:58 PM Jason Wang <jasowang at redhat.com> wrote: > > > > On Mon, Nov 14, 2022 at 3:16 PM Xie Yongji <xieyongji at bytedance.com> wrote: > > > > > > Add sysfs interface for each vduse virtqueue to setup > > > irq affinity. This would be useful for performance > > > tuning, e.g., mitigate the virtqueue lock contention > > > in virtio block driver. > > > > Do we have any perforamnce numbers for this? > > > > Almost 50% improvement (600k iops -> 900k iops) in the high iops > workloads. I have mentioned it in the cover-letter.For some reason, I miss that. I also wonder if we can do this automatically, then there's no need to play with sysfs which is kind of a burden for the management layer. Thanks> > > Btw, I wonder if irq is the best for the name since we actually don't > > use IRQ at all. I guess using "callback" might be better? > > > > Looks good to me. > > Thanks, > Yongji >