Virtualization - Aug 2022 - [PATCH v2 1/4] Make place for common balloon code

On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov
wrote:
> Hello,
> 
> On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
> 
> > >   rename include/linux/{balloon_compaction.h =>
balloon_common.h} (99%)
> > 
> > Why rename the .h file?  It still handles the "balloon
compaction"
> > logic.
> 
> File contains code that is common to balloon drivers,
> compaction is only part of it. Series add more code to it.
> Since it was suggested to use it for such common code.
> I find that common becomes a better name for it so the rename.
> I can drop the rename easy on next iteration if you suggest to.
"balloon_common.h" is very vague, you should only need one balloon.h
file in the include/linux/ directory, right, so of course it is
"common"
:)

thanks,

greg "naming is hard" k-h

On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman
wrote:
> On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote:
> > Hello,
> > 
> > On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov
wrote:
> > 
> > > >   rename include/linux/{balloon_compaction.h =>
balloon_common.h} (99%)
> > > 
> > > Why rename the .h file?  It still handles the "balloon
compaction"
> > > logic.
> > 
> > File contains code that is common to balloon drivers,
> > compaction is only part of it. Series add more code to it.
> > Since it was suggested to use it for such common code.
> > I find that common becomes a better name for it so the rename.
> > I can drop the rename easy on next iteration if you suggest to.
> 
> "balloon_common.h" is very vague, you should only need one
balloon.h
> file in the include/linux/ directory, right, so of course it is
"common"
> :)
> 
> thanks,
> 
> greg "naming is hard" k-h
Yea, just call it balloon.h and balloon.c then.

-- 
MST