Michael S. Tsirkin
2022-Aug-09 10:35 UTC
[PATCH v4 1/1] Create debugfs file with virtio balloon usage information
On Tue, Jul 05, 2022 at 12:01:58PM +0300, Alexander Atanasov wrote:> > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > > > index ddaa45e723c4..f3ff7c4e5884 100644 > > > --- a/include/uapi/linux/virtio_balloon.h > > > +++ b/include/uapi/linux/virtio_balloon.h > > > @@ -40,6 +40,7 @@ > > > /* Size of a PFN in the balloon interface. */ > > > #define VIRTIO_BALLOON_PFN_SHIFT 12 > > > +#define VIRTIO_BALLOON_PAGE_SIZE (1<<VIRTIO_BALLOON_PFN_SHIFT) > > > #define VIRTIO_BALLOON_CMD_ID_STOP 0 > > > #define VIRTIO_BALLOON_CMD_ID_DONE 1 > > Did you run checkpatch on this? > > > Sure, i did: > > scripts/checkpatch.pl > ../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch > total: 0 errors, 0 warnings, 108 lines checked > > ../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch > has no obvious style problems and is ready for submission.Weird. There should be spaces around << I think. -- MST