Stefano Garzarella
2022-Jun-20 09:37 UTC
[PATCH] virtio: Remove unnecessary variable assignments
Hi Bo, On Mon, Jun 20, 2022 at 09:32:28AM +0000, Bo Liu (??)-???? wrote:>Hi > >>On Fri, Jun 17, 2022 at 01:59:52AM -0400, Bo Liu wrote: >>>In function vp_modern_probe(), "mdev->pci_dev" is assigned to >>>variable >>>"pci_dev", variable "pci_dev" and "mdev->pci_dev" have the same >>>value. >>>There is no need to assign variable "pci_dev" to "mdev->pci_dev". So >>>remove it. >>> >> >>I suggest rephrasing the description a bit. >>Maybe into something like this: >> >> In function vp_modern_probe(), "pci_dev" is initialized with the >> value of "mdev->pci_dev", so assigning "pci_dev" to >> "mdev->pci_dev" >> is unnecessary since they store the same value. >> >>Anyway, the patch LGTM: >> >>Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> >> >The new patch is: > >In function vp_modern_probe(), "pci_dev" is initialized with the >value of "mdev->pci_dev", so assigning "pci_dev" to "mdev->pci_dev" >is unnecessary since they store the same value. > >Signed-off-by: Bo Liu <liubo03 at inspur.com> >--- > drivers/virtio/virtio_pci_modern_dev.c | 2 -- > 1 file changed, 2 deletions(-)It looks good, but I think it is better to send a proper v2. You can also add my R-b just before your S-o-b Thanks, Stefano