Greg KH
2022-Mar-09 18:33 UTC
[PATCH] VMCI: Fix a couple of failure paths in vmci_guest_probe_device()
On Wed, Mar 09, 2022 at 10:24:56AM -0800, Vishnu Dasa wrote:> notification_bitmap may not be released when VMCI_CAPS_DMA_DATAGRAM > capability is missing from the device. Add missing > 'err_free_notification_bitmap' label and use it instead of > 'err_free_data_buffers' to avoid this. > > free_irq() may be called to free an interrupt that was not > allocated. Add missing 'if' statement to check for > exclusive_vectors when freeing interrupt 1. > > Reported-by: Dan Carpenter <dan.carpenter at oracle.com> > Reviewed-by: Bryan Tan <bryantan at vmware.com> > Reviewed-by: Rajesh Jalisatgi <rjalisatgi at vmware.com> > Signed-off-by: Vishnu Dasa <vdasa at vmware.com> > --- > The patches which introduced these bugs are not in any released > kernels nor RC yet, so this fix does not need to be backported.So this has to get into 5.17-final? If not, it should be backported to 5.17, right? You should always include the "Fixes:" tag in the commit message so that we can figure this out. And shouldn't this be 2 different patches? Please break up. thanks, greg k-h