Bjorn Helgaas
2022-Feb-28 20:06 UTC
[PATCH v3 05/11] PCI: Use driver_set_override() instead of open-coding
On Sun, Feb 27, 2022 at 02:52:08PM +0100, Krzysztof Kozlowski wrote:> Use a helper for seting driver_override to reduce amount of duplicated > code. Make the driver_override field const char, because it is not > modified by the core and it matches other subsystems.s/seting/setting/ or even better, s/for seting/to set/> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>Acked-by: Bjorn Helgaas <bhelgaas at google.com>> - char *driver_override; /* Driver name to force a match */ > + /* > + * Driver name to force a match. > + * Do not set directly, because core frees it. > + * Use driver_set_override() to set or clear it.Wrap this comment to fill 78 columns or so.> + */ > + const char *driver_override; > > unsigned long priv_flags; /* Private flags for the PCI driver */ > > -- > 2.32.0 >