On 2022-01-28 11:32, John Garry wrote:> On 26/01/2022 17:00, Robin Murphy wrote:
>> As above, I vote for just forward-declaring the free routine in iova.c
>> and keeping it entirely private.
>
> BTW, speaking of forward declarations, it's possible to remove all the
> forward declarations in iova.c now that the FQ code is gone - but with a
> good bit of rearranging. However I am not sure how much people care
> about that or whether the code layout is sane...
Indeed, I was very tempted to raise the question there of whether there
was any more cleanup or refactoring that could be done to justify
collecting all the rcache code together at the top of iova.c. But in the
end I didn't, so my opinion still remains a secret...
Robin.