Michael S. Tsirkin
2022-Jan-14 19:57 UTC
[PATCH] virtio: unexport virtio_finalize_features
virtio_finalize_features is only used internally within virtio.
No reason to export it.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
drivers/virtio/virtio.c | 3 +--
include/linux/virtio.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 00ac9db792a4..d891b0a354b0 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -166,7 +166,7 @@ void virtio_add_status(struct virtio_device *dev, unsigned
int status)
}
EXPORT_SYMBOL_GPL(virtio_add_status);
-int virtio_finalize_features(struct virtio_device *dev)
+static int virtio_finalize_features(struct virtio_device *dev)
{
int ret = dev->config->finalize_features(dev);
unsigned status;
@@ -202,7 +202,6 @@ int virtio_finalize_features(struct virtio_device *dev)
}
return 0;
}
-EXPORT_SYMBOL_GPL(virtio_finalize_features);
void virtio_reset_device(struct virtio_device *dev)
{
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 72292a62cd90..5464f398912a 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -133,7 +133,6 @@ bool is_virtio_device(struct device *dev);
void virtio_break_device(struct virtio_device *dev);
void virtio_config_changed(struct virtio_device *dev);
-int virtio_finalize_features(struct virtio_device *dev);
#ifdef CONFIG_PM_SLEEP
int virtio_device_freeze(struct virtio_device *dev);
int virtio_device_restore(struct virtio_device *dev);
--
MST
? 2022/1/15 ??3:57, Michael S. Tsirkin ??:> virtio_finalize_features is only used internally within virtio. > No reason to export it. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Acked-by: Jason Wang <jasowang at redhat.com>> --- > drivers/virtio/virtio.c | 3 +-- > include/linux/virtio.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index 00ac9db792a4..d891b0a354b0 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -166,7 +166,7 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) > } > EXPORT_SYMBOL_GPL(virtio_add_status); > > -int virtio_finalize_features(struct virtio_device *dev) > +static int virtio_finalize_features(struct virtio_device *dev) > { > int ret = dev->config->finalize_features(dev); > unsigned status; > @@ -202,7 +202,6 @@ int virtio_finalize_features(struct virtio_device *dev) > } > return 0; > } > -EXPORT_SYMBOL_GPL(virtio_finalize_features); > > void virtio_reset_device(struct virtio_device *dev) > { > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > index 72292a62cd90..5464f398912a 100644 > --- a/include/linux/virtio.h > +++ b/include/linux/virtio.h > @@ -133,7 +133,6 @@ bool is_virtio_device(struct device *dev); > void virtio_break_device(struct virtio_device *dev); > > void virtio_config_changed(struct virtio_device *dev); > -int virtio_finalize_features(struct virtio_device *dev); > #ifdef CONFIG_PM_SLEEP > int virtio_device_freeze(struct virtio_device *dev); > int virtio_device_restore(struct virtio_device *dev);
On Fri, Jan 14 2022, "Michael S. Tsirkin" <mst at redhat.com> wrote:> virtio_finalize_features is only used internally within virtio. > No reason to export it. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio.c | 3 +-- > include/linux/virtio.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) >And nobody else really should use it. Reviewed-by: Cornelia Huck <cohuck at redhat.com>