Parav Pandit
2021-Dec-30 14:49 UTC
[PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0
> From: Eli Cohen <elic at nvidia.com> > Sent: Thursday, December 30, 2021 7:50 PM > > Remove overriding of virtio_version_1_0 which forced the virtqueue object to > version 1. > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 > devices") > Signed-off-by: Eli Cohen <elic at nvidia.com> > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 1eb473cb9d4d..e946a36bf7ee 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -871,8 +871,6 @@ static int create_virtqueue(struct mlx5_vdpa_net > *ndev, struct mlx5_vdpa_virtque > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id); > MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size); > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn); > - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, > eth_frame_offload_type)) > - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1); > > err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out)); > if (err) > -- > 2.34.1Reviewed-by: Parav Pandit <parav at nvidia.com>
Jason Wang
2022-Jan-04 02:43 UTC
[PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0
On Thu, Dec 30, 2021 at 10:49 PM Parav Pandit <parav at nvidia.com> wrote:> > > > From: Eli Cohen <elic at nvidia.com> > > Sent: Thursday, December 30, 2021 7:50 PM > > > > Remove overriding of virtio_version_1_0 which forced the virtqueue object to > > version 1. > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 > > devices") > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > --- > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > index 1eb473cb9d4d..e946a36bf7ee 100644 > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > @@ -871,8 +871,6 @@ static int create_virtqueue(struct mlx5_vdpa_net > > *ndev, struct mlx5_vdpa_virtque > > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id); > > MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size); > > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn); > > - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, > > eth_frame_offload_type)) > > - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1); > > > > err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out)); > > if (err) > > -- > > 2.34.1 > > Reviewed-by: Parav Pandit <parav at nvidia.com> >Acked-by: Jason Wang <jasowang at redhat.com>