David Ahern
2021-Nov-30 17:56 UTC
[PATCH v2 net-next 00/26] net: introduce and use generic XDP stats
On 11/30/21 10:07 AM, Jakub Kicinski wrote:> On Tue, 30 Nov 2021 17:17:24 +0100 Toke H?iland-J?rgensen wrote: >>> 1. Channels vs queues vs global. >>> >>> Jakub: no per-channel. >>> David (Ahern): it's worth it to separate as Rx/Tx. >>> Toke is fine with globals at the end I think? >> >> Well, I don't like throwing data away, so in that sense I do like >> per-queue stats, but it's not a very strong preference (i.e., I can live >> with either)... > > We don't even have a clear definition of a queue in Linux. >The summary above says "Jakub: no per-channel", and then you have this comment about a clear definition of a queue. What is your preference here, Jakub? I think I have gotten lost in all of the coments. My request was just to not lump Rx and Tx together under a 'channel' definition as a new API. Proposals like zctap and 'queues as a first class citizen' are examples of intentions / desires to move towards Rx and Tx queues beyond what exists today.