Srivatsa S. Bhat
2021-Nov-10 17:20 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
On Tue, Nov 09, 2021 at 01:57:31PM -0800, Joe Perches wrote:> On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote: > > > On Nov 8, 2021, at 4:37 PM, Joe Perches <joe at perches.com> wrote: > > > On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote: > > > > > > So it's an exploder not an actual maintainer and it likely isn't > > > publically archived with any normal list mechanism. > > > > > > So IMO "private" isn't appropriate. Neither is "L:" > > > Perhaps just mark it as what it is as an "exploder". > > > > > > Or maybe these blocks should be similar to: > > > > > > M: Name of Lead Developer <somebody at vmware.com> > > > M: VMware <foo> maintainers <linux-<foo>-maintainers at vmlinux.com> > > Maybe adding entries like > > M: Named maintainer <whoever at vmware.com> > R: VMware <foo> reviewers <linux-<foo>-maintainers at vmware.com> > > would be best/simplest. >Sure, that sounds good to me. I also considered adding "(email alias)" like Juergen suggested, but I think the R: entry is clear enough. Please find the updated patch below. --->From f66faa238facf504cfc66325912ce7af8cbf79ec Mon Sep 17 00:00:00 2001From: "Srivatsa S. Bhat (VMware)" <srivatsa at csail.mit.edu> Date: Mon, 8 Nov 2021 11:46:57 -0800 Subject: [PATCH v2 2/2] MAINTAINERS: Mark VMware mailing list entries as email aliases VMware mailing lists in the MAINTAINERS file are private lists meant for VMware-internal review/notification for patches to the respective subsystems. Anyone can post to these addresses, but there is no public read access like open mailing lists, which makes them more like email aliases instead (to reach out to reviewers). So update all the VMware mailing list references in the MAINTAINERS file to mark them as such, using "R: email-alias at vmware.com". Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> Cc: Zack Rusin <zackr at vmware.com> Cc: Nadav Amit <namit at vmware.com> Cc: Vivek Thampi <vithampi at vmware.com> Cc: Vishal Bhakta <vbhakta at vmware.com> Cc: Ronak Doshi <doshir at vmware.com> Cc: pv-drivers at vmware.com Cc: linux-graphics-maintainer at vmware.com Cc: dri-devel at lists.freedesktop.org Cc: linux-rdma at vger.kernel.org Cc: linux-scsi at vger.kernel.org Cc: netdev at vger.kernel.org Cc: linux-input at vger.kernel.org --- MAINTAINERS | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 118cf8170d02..4372d79027e9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: drivers/gpu/drm/vboxvideo/ DRM DRIVER FOR VMWARE VIRTUAL GPU -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> M: Zack Rusin <zackr at vmware.com> +R: VMware Graphics Reviewers <linux-graphics-maintainer at vmware.com> L: dri-devel at lists.freedesktop.org S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc @@ -14189,7 +14189,7 @@ F: include/uapi/linux/ppdev.h PARAVIRT_OPS INTERFACE M: Juergen Gross <jgross at suse.com> M: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> -L: pv-drivers at vmware.com (private) +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: virtualization at lists.linux-foundation.org L: x86 at kernel.org S: Supported @@ -20032,7 +20032,7 @@ F: tools/testing/vsock/ VMWARE BALLOON DRIVER M: Nadav Amit <namit at vmware.com> -M: "VMware, Inc." <pv-drivers at vmware.com> +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: linux-kernel at vger.kernel.org S: Maintained F: drivers/misc/vmw_balloon.c @@ -20040,7 +20040,7 @@ F: drivers/misc/vmw_balloon.c VMWARE HYPERVISOR INTERFACE M: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> M: Alexey Makhalov <amakhalov at vmware.com> -L: pv-drivers at vmware.com (private) +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: virtualization at lists.linux-foundation.org L: x86 at kernel.org S: Supported @@ -20050,14 +20050,14 @@ F: arch/x86/kernel/cpu/vmware.c VMWARE PVRDMA DRIVER M: Adit Ranadive <aditr at vmware.com> -M: VMware PV-Drivers <pv-drivers at vmware.com> +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: linux-rdma at vger.kernel.org S: Maintained F: drivers/infiniband/hw/vmw_pvrdma/ VMware PVSCSI driver M: Vishal Bhakta <vbhakta at vmware.com> -M: VMware PV-Drivers <pv-drivers at vmware.com> +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: linux-scsi at vger.kernel.org S: Maintained F: drivers/scsi/vmw_pvscsi.c @@ -20065,7 +20065,7 @@ F: drivers/scsi/vmw_pvscsi.h VMWARE VIRTUAL PTP CLOCK DRIVER M: Vivek Thampi <vithampi at vmware.com> -M: "VMware, Inc." <pv-drivers at vmware.com> +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: netdev at vger.kernel.org S: Supported F: drivers/ptp/ptp_vmw.c @@ -20073,14 +20073,14 @@ F: drivers/ptp/ptp_vmw.c VMWARE VMCI DRIVER M: Jorgen Hansen <jhansen at vmware.com> M: Vishnu Dasa <vdasa at vmware.com> +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: linux-kernel at vger.kernel.org -L: pv-drivers at vmware.com (private) S: Maintained F: drivers/misc/vmw_vmci/ VMWARE VMMOUSE SUBDRIVER -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> -M: "VMware, Inc." <pv-drivers at vmware.com> +R: VMware Graphics Reviewers <linux-graphics-maintainer at vmware.com> +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: linux-input at vger.kernel.org S: Maintained F: drivers/input/mouse/vmmouse.c @@ -20088,7 +20088,7 @@ F: drivers/input/mouse/vmmouse.h VMWARE VMXNET3 ETHERNET DRIVER M: Ronak Doshi <doshir at vmware.com> -M: pv-drivers at vmware.com +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com> L: netdev at vger.kernel.org S: Maintained F: drivers/net/vmxnet3/ -- 2.25.1
Nadav Amit
2021-Nov-10 17:40 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
> On Nov 10, 2021, at 9:20 AM, Srivatsa S. Bhat <srivatsa at csail.mit.edu> wrote: > > On Tue, Nov 09, 2021 at 01:57:31PM -0800, Joe Perches wrote: >> On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote: >>>> On Nov 8, 2021, at 4:37 PM, Joe Perches <joe at perches.com> wrote: >>>> On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote: >>>> >>>> So it's an exploder not an actual maintainer and it likely isn't >>>> publically archived with any normal list mechanism. >>>> >>>> So IMO "private" isn't appropriate. Neither is "L:" >>>> Perhaps just mark it as what it is as an "exploder". >>>> >>>> Or maybe these blocks should be similar to: >>>> >>>> M: Name of Lead Developer <somebody at vmware.com> >>>> M: VMware <foo> maintainers <linux-<foo>-maintainers at vmlinux.com> >> >> Maybe adding entries like >> >> M: Named maintainer <whoever at vmware.com> >> R: VMware <foo> reviewers <linux-<foo>-maintainers at vmware.com> >> >> would be best/simplest. >> > > Sure, that sounds good to me. I also considered adding "(email alias)" > like Juergen suggested, but I think the R: entry is clear enough. > Please find the updated patch below. > > --- > > From f66faa238facf504cfc66325912ce7af8cbf79ec Mon Sep 17 00:00:00 2001 > From: "Srivatsa S. Bhat (VMware)" <srivatsa at csail.mit.edu> > Date: Mon, 8 Nov 2021 11:46:57 -0800 > Subject: [PATCH v2 2/2] MAINTAINERS: Mark VMware mailing list entries as email > aliases > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. Anyone can post to these addresses, but there is no public > read access like open mailing lists, which makes them more like email > aliases instead (to reach out to reviewers). > > So update all the VMware mailing list references in the MAINTAINERS > file to mark them as such, using "R: email-alias at vmware.com". > > Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> > Cc: Zack Rusin <zackr at vmware.com> > Cc: Nadav Amit <namit at vmware.com> > Cc: Vivek Thampi <vithampi at vmware.com> > Cc: Vishal Bhakta <vbhakta at vmware.com> > Cc: Ronak Doshi <doshir at vmware.com> > Cc: pv-drivers at vmware.com > Cc: linux-graphics-maintainer at vmware.com > Cc: dri-devel at lists.freedesktop.org > Cc: linux-rdma at vger.kernel.org > Cc: linux-scsi at vger.kernel.org > Cc: netdev at vger.kernel.org > Cc: linux-input at vger.kernel.org > --- > MAINTAINERS | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 118cf8170d02..4372d79027e9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: drivers/gpu/drm/vboxvideo/ > > DRM DRIVER FOR VMWARE VIRTUAL GPU > -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> > M: Zack Rusin <zackr at vmware.com> > +R: VMware Graphics Reviewers <linux-graphics-maintainer at vmware.com> > L: dri-devel at lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > @@ -14189,7 +14189,7 @@ F: include/uapi/linux/ppdev.h > PARAVIRT_OPS INTERFACE > M: Juergen Gross <jgross at suse.com> > M: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> > -L: pv-drivers at vmware.com (private) > +R: VMware PV-Drivers Reviewers <pv-drivers at vmware.com>This patch that you just sent seems to go on top of the previous patches (as it removes "L: pv-drivers at vmware.com (private)?). Since the patches were still not merged, I would presume you should squash the old 2/2 with this new patch and send v3 of these patches.