Srivatsa S. Bhat
2021-Nov-08 20:30 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
From: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> VMware mailing lists in the MAINTAINERS file are private lists meant for VMware-internal review/notification for patches to the respective subsystems. So, in an earlier discussion [1][2], it was recommended to mark them as such. Update all the remaining VMware mailing list references to use that format -- "L: list at address (private)". [1]. https://lore.kernel.org/r/YPfp0Ff6KuyPlyrc at kroah.com [2]. https://lore.kernel.org/r/1626861766-11115-1-git-send-email-jhansen at vmware.com Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> Cc: Nadav Amit <namit at vmware.com> Cc: Vivek Thampi <vithampi at vmware.com> Cc: Vishal Bhakta <vbhakta at vmware.com> Cc: Ronak Doshi <doshir at vmware.com> Cc: pv-drivers at vmware.com Cc: linux-graphics-maintainer at vmware.com Cc: dri-devel at lists.freedesktop.org Cc: linux-rdma at vger.kernel.org Cc: linux-scsi at vger.kernel.org Cc: netdev at vger.kernel.org Cc: linux-input at vger.kernel.org Acked-by: Zack Rusin <zackr at vmware.com> --- MAINTAINERS | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 118cf8170d02..3e92176e68fb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: drivers/gpu/drm/vboxvideo/ DRM DRIVER FOR VMWARE VIRTUAL GPU -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> M: Zack Rusin <zackr at vmware.com> +L: linux-graphics-maintainer at vmware.com (private) L: dri-devel at lists.freedesktop.org S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc @@ -20032,7 +20032,7 @@ F: tools/testing/vsock/ VMWARE BALLOON DRIVER M: Nadav Amit <namit at vmware.com> -M: "VMware, Inc." <pv-drivers at vmware.com> +L: pv-drivers at vmware.com (private) L: linux-kernel at vger.kernel.org S: Maintained F: drivers/misc/vmw_balloon.c @@ -20050,14 +20050,14 @@ F: arch/x86/kernel/cpu/vmware.c VMWARE PVRDMA DRIVER M: Adit Ranadive <aditr at vmware.com> -M: VMware PV-Drivers <pv-drivers at vmware.com> +L: pv-drivers at vmware.com (private) L: linux-rdma at vger.kernel.org S: Maintained F: drivers/infiniband/hw/vmw_pvrdma/ VMware PVSCSI driver M: Vishal Bhakta <vbhakta at vmware.com> -M: VMware PV-Drivers <pv-drivers at vmware.com> +L: pv-drivers at vmware.com (private) L: linux-scsi at vger.kernel.org S: Maintained F: drivers/scsi/vmw_pvscsi.c @@ -20065,7 +20065,7 @@ F: drivers/scsi/vmw_pvscsi.h VMWARE VIRTUAL PTP CLOCK DRIVER M: Vivek Thampi <vithampi at vmware.com> -M: "VMware, Inc." <pv-drivers at vmware.com> +L: pv-drivers at vmware.com (private) L: netdev at vger.kernel.org S: Supported F: drivers/ptp/ptp_vmw.c @@ -20079,8 +20079,8 @@ S: Maintained F: drivers/misc/vmw_vmci/ VMWARE VMMOUSE SUBDRIVER -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> -M: "VMware, Inc." <pv-drivers at vmware.com> +L: linux-graphics-maintainer at vmware.com (private) +L: pv-drivers at vmware.com (private) L: linux-input at vger.kernel.org S: Maintained F: drivers/input/mouse/vmmouse.c @@ -20088,7 +20088,7 @@ F: drivers/input/mouse/vmmouse.h VMWARE VMXNET3 ETHERNET DRIVER M: Ronak Doshi <doshir at vmware.com> -M: pv-drivers at vmware.com +L: pv-drivers at vmware.com (private) L: netdev at vger.kernel.org S: Maintained F: drivers/net/vmxnet3/
Nadav Amit
2021-Nov-08 20:45 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
> On Nov 8, 2021, at 12:30 PM, Srivatsa S. Bhat <srivatsa at csail.mit.edu> wrote: > > From: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. So, in an earlier discussion [1][2], it was recommended to > mark them as such. Update all the remaining VMware mailing list > references to use that format -- "L: list at address (private)?.Acked-by: Nadav Amit <namit at vmware.com>
Joe Perches
2021-Nov-08 23:37 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote:> From: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. So, in an earlier discussion [1][2], it was recommended to > mark them as such. Update all the remaining VMware mailing list > references to use that format -- "L: list at address (private)".[]> diff --git a/MAINTAINERS b/MAINTAINERS[]> @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: drivers/gpu/drm/vboxvideo/ > > DRM DRIVER FOR VMWARE VIRTUAL GPU > -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> > M: Zack Rusin <zackr at vmware.com> > +L: linux-graphics-maintainer at vmware.com (private)This MAINTAINERS file is for _public_ use, marking something non-public isn't useful. private makes no sense and likely these L: entries shouldn't exist.
Srivatsa S. Bhat
2021-Nov-09 00:22 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
+Greg, Thomas Hi Joe, On 11/8/21 3:37 PM, Joe Perches wrote:> On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote: >> From: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> >> >> VMware mailing lists in the MAINTAINERS file are private lists meant >> for VMware-internal review/notification for patches to the respective >> subsystems. So, in an earlier discussion [1][2], it was recommended to >> mark them as such. Update all the remaining VMware mailing list >> references to use that format -- "L: list at address (private)". > [] >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc >> F: drivers/gpu/drm/vboxvideo/ >> >> DRM DRIVER FOR VMWARE VIRTUAL GPU >> -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> >> M: Zack Rusin <zackr at vmware.com> >> +L: linux-graphics-maintainer at vmware.com (private) > > This MAINTAINERS file is for _public_ use, marking something > non-public isn't useful. > > private makes no sense and likely these L: entries shouldn't exist. > >Well, the public can send messages to this list, but membership is restricted. In many ways, I believe this is similar to x86 at kernel.org, which is an email alias that anyone can post to in order to reach the x86 maintainer community for patch review. I see x86 at kernel.org listed as both L: and M: in the MAINTAINERS file, among different entries. Although the @vmware list ids refer to VMware-internal mailing lists as opposed to email aliases, they serve a very similar purpose -- to inform VMware folks about patches to the relevant subsystems. Is there a consensus on how such lists should be specified? One suggestion (from Greg in the email thread referenced above) was to mark it as private, which is what this patch does. Maybe we can find a better alternative? How about specifying such lists using M: (indicating that this address can be used to reach maintainers), as long as that is not the only M: entry for a given subsystem (i.e., it includes real people's email id as well)? I think that would address Greg's primary objection too from that other thread (related to personal responsibility as maintainers). Regards, Srivatsa
Juergen Gross
2021-Nov-09 05:34 UTC
[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private
On 08.11.21 21:30, Srivatsa S. Bhat wrote:> From: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. So, in an earlier discussion [1][2], it was recommended to > mark them as such. Update all the remaining VMware mailing list > references to use that format -- "L: list at address (private)". > > [1]. https://lore.kernel.org/r/YPfp0Ff6KuyPlyrc at kroah.com > [2]. https://lore.kernel.org/r/1626861766-11115-1-git-send-email-jhansen at vmware.com > > Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa at csail.mit.edu> > Cc: Nadav Amit <namit at vmware.com> > Cc: Vivek Thampi <vithampi at vmware.com> > Cc: Vishal Bhakta <vbhakta at vmware.com> > Cc: Ronak Doshi <doshir at vmware.com> > Cc: pv-drivers at vmware.com > Cc: linux-graphics-maintainer at vmware.com > Cc: dri-devel at lists.freedesktop.org > Cc: linux-rdma at vger.kernel.org > Cc: linux-scsi at vger.kernel.org > Cc: netdev at vger.kernel.org > Cc: linux-input at vger.kernel.org > Acked-by: Zack Rusin <zackr at vmware.com> > --- > > MAINTAINERS | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 118cf8170d02..3e92176e68fb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: drivers/gpu/drm/vboxvideo/ > > DRM DRIVER FOR VMWARE VIRTUAL GPU > -M: "VMware Graphics" <linux-graphics-maintainer at vmware.com> > M: Zack Rusin <zackr at vmware.com> > +L: linux-graphics-maintainer at vmware.com (private) > L: dri-devel at lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > @@ -20032,7 +20032,7 @@ F: tools/testing/vsock/ > > VMWARE BALLOON DRIVER > M: Nadav Amit <namit at vmware.com> > -M: "VMware, Inc." <pv-drivers at vmware.com> > +L: pv-drivers at vmware.com (private) > L: linux-kernel at vger.kernel.org > S: Maintained > F: drivers/misc/vmw_balloon.c > @@ -20050,14 +20050,14 @@ F: arch/x86/kernel/cpu/vmware.c > > VMWARE PVRDMA DRIVER > M: Adit Ranadive <aditr at vmware.com> > -M: VMware PV-Drivers <pv-drivers at vmware.com> > +L: pv-drivers at vmware.com (private) > L: linux-rdma at vger.kernel.org > S: Maintained > F: drivers/infiniband/hw/vmw_pvrdma/ > > VMware PVSCSI driver > M: Vishal Bhakta <vbhakta at vmware.com> > -M: VMware PV-Drivers <pv-drivers at vmware.com> > +L: pv-drivers at vmware.com (private) > L: linux-scsi at vger.kernel.org > S: Maintained > F: drivers/scsi/vmw_pvscsi.c > @@ -20065,7 +20065,7 @@ F: drivers/scsi/vmw_pvscsi.h > > VMWARE VIRTUAL PTP CLOCK DRIVER > M: Vivek Thampi <vithampi at vmware.com> > -M: "VMware, Inc." <pv-drivers at vmware.com> > +L: pv-drivers at vmware.com (private)Maybe replace "(private)" with "(mail alias)"? This makes it rather clear that it is a valid address to send patches to, but there isn't public read access like to a ML. Juergen -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_0xB0DE9DD628BF132F.asc Type: application/pgp-keys Size: 3091 bytes Desc: OpenPGP public key URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20211109/914d00f0/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 495 bytes Desc: OpenPGP digital signature URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20211109/914d00f0/attachment.sig>