Stefano Garzarella
2021-Jul-26 09:28 UTC
[PATCH 3/4] vDPA/ifcvf: Fix return value check for vdpa_alloc_device()
On Thu, Jul 15, 2021 at 04:00:25PM +0800, Xie Yongji wrote:>The vdpa_alloc_device() returns an error pointer upon >failure, not NULL. To handle the failure correctly, this >replaces NULL check with IS_ERR() check and propagate the >error upwards. > >Fixes: 5a2414bc454e ("virtio: Intel IFC VF driver for VDPA") >Reported-by: Dan Carpenter <dan.carpenter at oracle.com> >Signed-off-by: Xie Yongji <xieyongji at bytedance.com> >--- > drivers/vdpa/ifcvf/ifcvf_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c >index 21b78f1cd521..351c6cfb24c3 100644 >--- a/drivers/vdpa/ifcvf/ifcvf_main.c >+++ b/drivers/vdpa/ifcvf/ifcvf_main.c >@@ -493,9 +493,9 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > adapter = vdpa_alloc_device(struct ifcvf_adapter, vdpa, > dev, &ifc_vdpa_ops, NULL); >- if (adapter == NULL) { >+ if (IS_ERR(adapter)) { > IFCVF_ERR(pdev, "Failed to allocate vDPA structure"); >- return -ENOMEM; >+ return PTR_ERR(adapter); > } > > pci_set_master(pdev); >-- >2.11.0 >Reviewed-by: Stefano Garzarella <sgarzare at redhat.com>