Viresh Kumar
2021-Jul-26 09:21 UTC
[PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio
On 26-07-21, 10:11, Arnd Bergmann wrote:> On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann <arnd at kernel.org> wrote: > > > > On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar <viresh.kumar at linaro.org> wrote: > > > > > > This patch adds binding for virtio I2C device, it is based on > > > virtio-device bindings. > > > > > > Acked-by: Wolfram Sang <wsa at kernel.org> > > > Signed-off-by: Viresh Kumar <viresh.kumar at linaro.org> > > > > Reviewed-by: Arnd Bergmann <arnd at arndb.de> > > Too quick, after seeing the same issue in the gpio binding I saw it here too: > > > + i2c-virtio { > > + compatible = "virtio,22"; > > The node name "i2c-virtio" looks wrong. According to > https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml, > this needs to be plain "i2c".Okay, I will move back to simple node names then. Thanks. -- viresh