Viresh Kumar
2021-Jun-14 05:26 UTC
[Stratos-dev] [PATCH V3 1/3] gpio: Add virtio-gpio driver
On 11-06-21, 10:34, Arnd Bergmann wrote:> Extraneous __packed annotations do cause real problems: > > - On architectures without hardware unaligned accesses, the compiler is > forced to emit byte load/store instructions, which is slower and breaks > atomic updates to shared variables > > - If a function takes a pointer of a packed struct member, and passes that > pointer to a function that expects a regular aligned pointer, you > get undefined > behavior. Newer compilers produce a warning if you do that (we currently > shut up that warning because there are many false positives in the kernel), > but you can also run into CPU exceptions or broken code even on CPUs > that do support unaligned accesses when the variable ends up being > actually unaligned (as you just told the compiler that it is allowed to do).I understand that these problems will happen if the structure isn't aligned, but in this case the structure is aligned properly, just that we are explicitly telling the compiler to not add any padding (it won't have added any in here). Is it still harmful ? -- viresh