Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it
returns success.
Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use
vp_modern_map_vq_notify()")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c
b/drivers/vdpa/virtio_pci/vp_vdpa.c
index c76ebb531212..e5d92db728d3 100644
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
vp_modern_map_vq_notify(mdev, i,
&vp_vdpa->vring[i].notify_pa);
if (!vp_vdpa->vring[i].notify) {
+ ret = -ENOMEM;
dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
goto err;
}
--
2.30.2
? 2021/6/5 ??8:47, Dan Carpenter ??:> Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it > returns success. > > Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()") > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + > 1 file changed, 1 insertion(+)Acked-by: Jason Wang <jasowang at redhat.com> Thanks> > diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c > index c76ebb531212..e5d92db728d3 100644 > --- a/drivers/vdpa/virtio_pci/vp_vdpa.c > +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c > @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) > vp_modern_map_vq_notify(mdev, i, > &vp_vdpa->vring[i].notify_pa); > if (!vp_vdpa->vring[i].notify) { > + ret = -ENOMEM; > dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i); > goto err; > }
On Sat, Jun 05, 2021 at 03:47:28PM +0300, Dan Carpenter wrote:>Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it >returns success. > >Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()") >Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> >--- > drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c >index c76ebb531212..e5d92db728d3 100644 >--- a/drivers/vdpa/virtio_pci/vp_vdpa.c >+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c >@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) > vp_modern_map_vq_notify(mdev, i, > &vp_vdpa->vring[i].notify_pa); > if (!vp_vdpa->vring[i].notify) { >+ ret = -ENOMEM; > dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i); > goto err; > } >-- >2.30.2 >Reviewed-by: Stefano Garzarella <sgarzare at redhat.com>