Gerd Hoffmann
2021-Feb-03 13:16 UTC
[PATCH v5 4/6] drm/qxl: handle shadow in primary destroy
qxl_primary_atomic_disable must check whenever the framebuffer bo has a shadow surface and in case it has check the shadow primary status. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/qxl/qxl_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 60331e31861a..f5ee8cd72b5b 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -562,6 +562,8 @@ static void qxl_primary_atomic_disable(struct drm_plane *plane, if (old_state->fb) { struct qxl_bo *bo = gem_to_qxl_bo(old_state->fb->obj[0]); + if (bo->shadow) + bo = bo->shadow; if (bo->is_primary) { qxl_io_destroy_primary(qdev); bo->is_primary = false; -- 2.29.2
Thomas Zimmermann
2021-Feb-03 14:07 UTC
[PATCH v5 4/6] drm/qxl: handle shadow in primary destroy
Am 03.02.21 um 14:16 schrieb Gerd Hoffmann:> qxl_primary_atomic_disable must check whenever the framebuffer bo has a > shadow surface and in case it has check the shadow primary status.I believe you :) Acked-by: Thomas Zimmermann <tzimmermann at suse.de>> > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > --- > drivers/gpu/drm/qxl/qxl_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > index 60331e31861a..f5ee8cd72b5b 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -562,6 +562,8 @@ static void qxl_primary_atomic_disable(struct drm_plane *plane, > if (old_state->fb) { > struct qxl_bo *bo = gem_to_qxl_bo(old_state->fb->obj[0]); > > + if (bo->shadow) > + bo = bo->shadow; > if (bo->is_primary) { > qxl_io_destroy_primary(qdev); > bo->is_primary = false; >-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Felix Imend?rffer -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20210203/0175520b/attachment.sig>