Stefan Hajnoczi
2020-Dec-08 08:25 UTC
[RFC PATCH 16/27] virtio: Expose virtqueue_alloc_element
On Fri, Nov 20, 2020 at 07:50:54PM +0100, Eugenio P?rez wrote:> Specify VirtQueueElement * as return type makes no harm at this moment.The reason for the void * return type is that C implicitly converts void pointers to pointers of any type. The function takes a size_t sz argument so it can allocate a object of user-defined size. The idea is that the user's struct embeds a VirtQueueElement field. Changing the return type to VirtQueueElement * means that callers may need to explicitly cast to the user's struct type. It's a question of coding style but I think the void * return type communicates what is going on better than VirtQueueElement *. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20201208/1b2455f3/attachment.sig>