Jason Wang
2020-Aug-05 08:12 UTC
[PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices
On 2020/8/5 ??1:01, Eli Cohen wrote:> On Tue, Aug 04, 2020 at 05:29:09PM -0400, Michael S. Tsirkin wrote: >> On Tue, Aug 04, 2020 at 07:20:36PM +0300, Eli Cohen wrote: >>> Hi Michael, >>> please note that this series depends on mlx5 core device driver patches >>> in mlx5-next branch in >>> git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git. >> Thanks! OK so what's the plan for merging this? >> Do patches at least build well enough that I can push them >> upstream? Or do they have to go on top of the mellanox tree? >> > The patches are built on your linux-next branch which I updated > yesterday. > > I am based on this commit: > 776b7b25f10b (origin/linux-next) vhost: add an RPMsg API > > On top of that I merged > git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git > > and after that I have Jason's patches (five patches), than one patch > from Max and then my patches (seven). > > It builds fine on x84_64. > I fixed some conflicts on Jason's patches. > > I also tested it to verify it's working. > > BTW, for some reason I did not get all the patches into my mailbox and I > suspect they were not all sent. Did you get all the series 0-13?I can see patch 0 to patch 12 but not patch 13 (I guess 12 is all). Thanks> > Please let me know, and if needed I'll resend. > >>> git pull git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-next >>> >>> They also depend Jason Wang's patches: https://lkml.org/lkml/2020/7/1/301 >> The ones you included, right? >> > Right. > >>> Jason, I had to resolve some conflicts so I would appreciate of you can verify >>> that it is ok. >>> >>> The following series of patches provide VDPA support for Mellanox >>> devices. The supported devices are ConnectX6 DX and newer. >>> >>> Currently, only a network driver is implemented; future patches will >>> introduce a block device driver. iperf performance on a single queue is >>> around 12 Gbps. Future patches will introduce multi queue support. >>> >>> The files are organized in such a way that code that can be used by >>> different VDPA implementations will be placed in a common are resides in >>> drivers/vdpa/mlx5/core. >>> >>> Only virtual functions are currently supported. Also, certain firmware >>> capabilities must be set to enable the driver. Physical functions (PFs) >>> are skipped by the driver. >>> >>> To make use of the VDPA net driver, one must load mlx5_vdpa. In such >>> case, VFs will be operated by the VDPA driver. Although one can see a >>> regular instance of a network driver on the VF, the VDPA driver takes >>> precedence over the NIC driver, steering-wize. >>> >>> Currently, the device/interface infrastructure in mlx5_core is used to >>> probe drivers. Future patches will introduce virtbus as a means to >>> register devices and drivers and VDPA will be adapted to it. >>> >>> The mlx5 mode of operation required to support VDPA is switchdev mode. >>> Once can use Linux or OVS bridge to take care of layer 2 switching. >>> >>> In order to provide virtio networking to a guest, an updated version of >>> qemu is required. This version has been tested by the following quemu >>> version: >>> >>> url: https://github.com/jasowang/qemu.git >>> branch: vdpa >>> Commit ID: 6f4e59b807db >>> >>> >>> V2->V3 >>> Fix makefile to use include path relative to the root of the kernel >>> >>> V3-V4 >>> Rebase Jason's patches on linux-next branch >>> Fix krobot error on mips arch >>> Make use of the free callback to destroy resoruces on unload >>> Use VIRTIO_F_ACCESS_PLATFORM instead of legacy VIRTIO_F_IOMMU_PLATFORM >>> Add empty implementations for get_vq_notification() and get_vq_irq() >>> >>> >>> Eli Cohen (6): >>> net/vdpa: Use struct for set/get vq state >>> vdpa: Modify get_vq_state() to return error code >>> vdpa/mlx5: Add hardware descriptive header file >>> vdpa/mlx5: Add support library for mlx5 VDPA implementation >>> vdpa/mlx5: Add shared memory registration code >>> vdpa/mlx5: Add VDPA driver for supported mlx5 devices >>> >>> Jason Wang (5): >>> vhost-vdpa: refine ioctl pre-processing >>> vhost: generialize backend features setting/getting >>> vhost-vdpa: support get/set backend features >>> vhost-vdpa: support IOTLB batching hints >>> vdpasim: support batch updating >>> >>> Max Gurtovoy (1): >>> vdpa: remove hard coded virtq num >>> >>> drivers/vdpa/Kconfig | 19 + >>> drivers/vdpa/Makefile | 1 + >>> drivers/vdpa/ifcvf/ifcvf_base.c | 4 +- >>> drivers/vdpa/ifcvf/ifcvf_base.h | 4 +- >>> drivers/vdpa/ifcvf/ifcvf_main.c | 13 +- >>> drivers/vdpa/mlx5/Makefile | 4 + >>> drivers/vdpa/mlx5/core/mlx5_vdpa.h | 91 ++ >>> drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 ++ >>> drivers/vdpa/mlx5/core/mr.c | 484 ++++++ >>> drivers/vdpa/mlx5/core/resources.c | 284 ++++ >>> drivers/vdpa/mlx5/net/main.c | 76 + >>> drivers/vdpa/mlx5/net/mlx5_vnet.c | 1965 ++++++++++++++++++++++++ >>> drivers/vdpa/mlx5/net/mlx5_vnet.h | 24 + >>> drivers/vdpa/vdpa.c | 3 + >>> drivers/vdpa/vdpa_sim/vdpa_sim.c | 53 +- >>> drivers/vhost/net.c | 18 +- >>> drivers/vhost/vdpa.c | 76 +- >>> drivers/vhost/vhost.c | 15 + >>> drivers/vhost/vhost.h | 2 + >>> include/linux/vdpa.h | 24 +- >>> include/uapi/linux/vhost.h | 2 + >>> include/uapi/linux/vhost_types.h | 11 + >>> 22 files changed, 3284 insertions(+), 57 deletions(-) >>> create mode 100644 drivers/vdpa/mlx5/Makefile >>> create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa.h >>> create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h >>> create mode 100644 drivers/vdpa/mlx5/core/mr.c >>> create mode 100644 drivers/vdpa/mlx5/core/resources.c >>> create mode 100644 drivers/vdpa/mlx5/net/main.c >>> create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.c >>> create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h >>> >>> -- >>> 2.26.0