balloon uses virtio32_to_cpu instead of cpu_to_virtio32 to convert a native endian number to virtio. No practical difference but makes sparse warn. Fix it up. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index fc7301406540..5d4b891bf84f 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -596,7 +596,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb) while (virtqueue_get_buf(vq, &unused)) ; - vb->cmd_id_active = virtio32_to_cpu(vb->vdev, + vb->cmd_id_active = cpu_to_virtio32(vb->vdev, virtio_balloon_cmd_id_received(vb)); sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); -- MST
On 10.07.20 12:48, Michael S. Tsirkin wrote:> balloon uses virtio32_to_cpu instead of cpu_to_virtio32 > to convert a native endian number to virtio. > No practical difference but makes sparse warn. > Fix it up. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index fc7301406540..5d4b891bf84f 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -596,7 +596,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb) > while (virtqueue_get_buf(vq, &unused)) > ; > > - vb->cmd_id_active = virtio32_to_cpu(vb->vdev, > + vb->cmd_id_active = cpu_to_virtio32(vb->vdev, > virtio_balloon_cmd_id_received(vb)); > sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); > err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); >Reviewed-by: David Hildenbrand <david at redhat.com> -- Thanks, David / dhildenb
On 2020/7/10 ??6:48, Michael S. Tsirkin wrote:> balloon uses virtio32_to_cpu instead of cpu_to_virtio32 > to convert a native endian number to virtio. > No practical difference but makes sparse warn. > Fix it up. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index fc7301406540..5d4b891bf84f 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -596,7 +596,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb) > while (virtqueue_get_buf(vq, &unused)) > ; > > - vb->cmd_id_active = virtio32_to_cpu(vb->vdev, > + vb->cmd_id_active = cpu_to_virtio32(vb->vdev, > virtio_balloon_cmd_id_received(vb)); > sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); > err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL);Acked-by: Jason Wang <jasowang at redhat.com>