Colin King
2020-Jul-01 13:41 UTC
[PATCH] drm/virtgpu: remove redundant assignments to width and height
From: Colin Ian King <colin.king at canonical.com>
Variables width and height are being assigned values that are never
read. The assignments are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c
b/drivers/gpu/drm/virtio/virtgpu_display.c
index f3ce49c5a34c..bf80d8c23da7 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -165,8 +165,6 @@ static int virtio_gpu_conn_get_modes(struct drm_connector
*connector)
count = drm_add_modes_noedid(connector, XRES_MAX, YRES_MAX);
if (width == 0 || height == 0) {
- width = XRES_DEF;
- height = YRES_DEF;
drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
} else {
DRM_DEBUG("add mode: %dx%d\n", width, height);
--
2.27.0
Gerd Hoffmann
2020-Aug-17 09:16 UTC
[PATCH] drm/virtgpu: remove redundant assignments to width and height
On Wed, Jul 01, 2020 at 02:41:54PM +0100, Colin King wrote:> From: Colin Ian King <colin.king at canonical.com> > > Variables width and height are being assigned values that are never > read. The assignments are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king at canonical.com>Pused to drm-misc-next. thanks, Gerd