Smatch complains that "rc" can be uninitialized if we hit the "break;" statement on the first iteration through the loop. I suspect that this can't happen in real life, but returning a zero literal is cleaner and silence the static checker warning. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- drivers/virtio/virtio_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index f658fe9149beb..893ef18060a02 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1192,7 +1192,7 @@ static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id, VIRTIO_MEM_MB_STATE_OFFLINE); } - return rc; + return 0; } /* -- 2.26.2
Michael S. Tsirkin
2020-Jun-10 09:39 UTC
[PATCH] virtio-mem: silence a static checker warning
On Wed, Jun 10, 2020 at 11:59:11AM +0300, Dan Carpenter wrote:> Smatch complains that "rc" can be uninitialized if we hit the "break;" > statement on the first iteration through the loop. I suspect that this > can't happen in real life, but returning a zero literal is cleaner and > silence the static checker warning. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > drivers/virtio/virtio_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)Applied, thanks.> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index f658fe9149beb..893ef18060a02 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -1192,7 +1192,7 @@ static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id, > VIRTIO_MEM_MB_STATE_OFFLINE); > } > > - return rc; > + return 0; > } > > /* > -- > 2.26.2
David Hildenbrand
2020-Jun-10 09:43 UTC
[PATCH] virtio-mem: silence a static checker warning
> Am 10.06.2020 um 10:59 schrieb Dan Carpenter <dan.carpenter at oracle.com>: > > ?Smatch complains that "rc" can be uninitialized if we hit the "break;" > statement on the first iteration through the loop. I suspect that this > can't happen in real life, but returning a zero literal is cleaner and > silence the static checker warning. >Right, it?s impossible in real life. Thanks! Acked-by: David Hildenbrand <david at redhat.com>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > drivers/virtio/virtio_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index f658fe9149beb..893ef18060a02 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -1192,7 +1192,7 @@ static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id, > VIRTIO_MEM_MB_STATE_OFFLINE); > } > > - return rc; > + return 0; > } > > /* > -- > 2.26.2 >