Huacai Chen
2020-Apr-24 09:57 UTC
[PATCH Resend] drm/qxl: Use correct notify port address when creating cursor ring
Hi, Gerd On Tue, Mar 31, 2020 at 10:53 PM Gerd Hoffmann <kraxel at redhat.com> wrote:> > On Tue, Mar 31, 2020 at 02:18:08PM +0800, Huacai Chen wrote: > > The command ring and cursor ring use different notify port addresses > > definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in > > qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring > > and cursor ring. This doesn't cause any problems now, because QEMU's > > behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. > > However, QEMU's behavior may be change in future, so let's fix it. > > > > P.S.: In the X.org QXL driver, the notify port address of cursor ring > > is correct. > > > > Cc: <stable at vger.kernel.org> > > Signed-off-by: Huacai Chen <chenhc at lemote.com> > > Pushed to drm-misc-next.It seems that this patch hasn't appear in upstream.> > thanks, > Gerd >Thanks, Huacai
Gerd Hoffmann
2020-Apr-24 09:58 UTC
[PATCH Resend] drm/qxl: Use correct notify port address when creating cursor ring
On Fri, Apr 24, 2020 at 05:57:37PM +0800, Huacai Chen wrote:> Hi, Gerd > > On Tue, Mar 31, 2020 at 10:53 PM Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > On Tue, Mar 31, 2020 at 02:18:08PM +0800, Huacai Chen wrote: > > > The command ring and cursor ring use different notify port addresses > > > definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in > > > qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring > > > and cursor ring. This doesn't cause any problems now, because QEMU's > > > behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. > > > However, QEMU's behavior may be change in future, so let's fix it. > > > > > > P.S.: In the X.org QXL driver, the notify port address of cursor ring > > > is correct. > > > > > > Cc: <stable at vger.kernel.org> > > > Signed-off-by: Huacai Chen <chenhc at lemote.com> > > > > Pushed to drm-misc-next. > It seems that this patch hasn't appear in upstream.Was probably to late for the 5.7 merge window, should land in 5.8 cheers, Gerd