Tiwei Bie
2018-Jun-01 10:22 UTC
[PATCH] virtio: update the comments for transport features
Suggested-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- This patch is generated on top of below patch: https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html include/uapi/linux/virtio_config.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index b7c1f4e7d59e..479affd903e9 100644 --- a/include/uapi/linux/virtio_config.h +++ b/include/uapi/linux/virtio_config.h @@ -45,9 +45,12 @@ /* We've given up on this device. */ #define VIRTIO_CONFIG_S_FAILED 0x80 -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the - * transport being used (eg. virtio_ring), the rest are per-device feature - * bits. */ +/* + * Some virtio feature bits (currently bits VIRTIO_TRANSPORT_F_START + * through VIRTIO_TRANSPORT_F_END) are reserved for the transport being + * used (e.g. virtio_ring, virtio_pci etc.), the rest are per-device + * feature bits. + */ #define VIRTIO_TRANSPORT_F_START 28 #define VIRTIO_TRANSPORT_F_END 38 -- 2.17.0
Cornelia Huck
2018-Jun-01 10:45 UTC
[virtio-dev] [PATCH] virtio: update the comments for transport features
On Fri, 1 Jun 2018 18:22:17 +0800 Tiwei Bie <tiwei.bie at intel.com> wrote:> Suggested-by: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > This patch is generated on top of below patch: > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html > > include/uapi/linux/virtio_config.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h > index b7c1f4e7d59e..479affd903e9 100644 > --- a/include/uapi/linux/virtio_config.h > +++ b/include/uapi/linux/virtio_config.h > @@ -45,9 +45,12 @@ > /* We've given up on this device. */ > #define VIRTIO_CONFIG_S_FAILED 0x80 > > -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the > - * transport being used (eg. virtio_ring), the rest are per-device feature > - * bits. */ > +/* > + * Some virtio feature bits (currently bits VIRTIO_TRANSPORT_F_START > + * through VIRTIO_TRANSPORT_F_END) are reserved for the transport beingIt will always be bits up to VIRTIO_TRANSPORT_F_END, no? So you can drop the "currently"? Or reword as "Virtio feature bits VIRTIO_TRANSPORT_F_START through VIRTIO_TRANSPORT_F_END are reserved..."?> + * used (e.g. virtio_ring, virtio_pci etc.), the rest are per-device > + * feature bits. > + */ > #define VIRTIO_TRANSPORT_F_START 28 > #define VIRTIO_TRANSPORT_F_END 38 >
Tiwei Bie
2018-Jun-01 10:52 UTC
[virtio-dev] [PATCH] virtio: update the comments for transport features
On Fri, Jun 01, 2018 at 12:45:52PM +0200, Cornelia Huck wrote:> On Fri, 1 Jun 2018 18:22:17 +0800 > Tiwei Bie <tiwei.bie at intel.com> wrote: > > > Suggested-by: Michael S. Tsirkin <mst at redhat.com> > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > > --- > > This patch is generated on top of below patch: > > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html > > > > include/uapi/linux/virtio_config.h | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h > > index b7c1f4e7d59e..479affd903e9 100644 > > --- a/include/uapi/linux/virtio_config.h > > +++ b/include/uapi/linux/virtio_config.h > > @@ -45,9 +45,12 @@ > > /* We've given up on this device. */ > > #define VIRTIO_CONFIG_S_FAILED 0x80 > > > > -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the > > - * transport being used (eg. virtio_ring), the rest are per-device feature > > - * bits. */ > > +/* > > + * Some virtio feature bits (currently bits VIRTIO_TRANSPORT_F_START > > + * through VIRTIO_TRANSPORT_F_END) are reserved for the transport being > > It will always be bits up to VIRTIO_TRANSPORT_F_END, no? So you can drop > the "currently"? > > Or reword as "Virtio feature bits VIRTIO_TRANSPORT_F_START through > VIRTIO_TRANSPORT_F_END are reserved..."?I will do it. Thanks for the suggestion! Best regards, Tiwei Bie