David Miller
2018-Apr-04 17:42 UTC
[RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice
From: David Ahern <dsahern at gmail.com> Date: Wed, 4 Apr 2018 11:37:52 -0600> Networking vendors have out of tree kernel modules. Those modules use a > netdev (call it a master netdev, a control netdev, cpu port, whatever) > to pull packets from the ASIC and deliver to virtual netdevices > representing physical ports. The master netdev should not be mucked with > by a user. It should be ignored by certain s/w with lldpd as just an > *example*.Two approaches: 1) Add an IFF_CONTROL and make userspace understand this. It is probably long overdue. 2) Design the driver properly. Have a non-netdev master device like mlxsw does, and control it using devlink or similar. This is exactly how this stuff was meant to be architected.> From there I think you are confusing my intentions: I fundamentally do > not believe the kernel should be hiding anything from an admin. Not > showing data by default is completely different than not showing that > data at all.It is the same David. It measn we have no intention of fixing applications to properly know what to do with and how to handle these devices. If you hide these objects, we are basically giving up on fixing the tools and or the drivers themselves to be architected differently (see #2 above). That really isn't acceptable in my opinion.> The intention of my patch with the IFF_HIDDEN attribute is: > 1. it is a netdev attribute > > 2. that attribute can be used by userpsace to indicate to the kernel I > want all or I want the default > > 3. that attribute can be controlled by an admin. > > The patches go beyond my specific use case (preventing a user from > modifying a netdev it should not be touching) but to defining the > semantics of a generic capability which is what the kernel should have."Teach, do not hide!" -Yoda