Michael S. Tsirkin
2017-Mar-10 16:17 UTC
[PATCH RFC] virtio_net: fix mergeable bufs error handling
On xdp error we try to free head_skb without having
initialized it, that's clearly bogus.
Fixes: f600b6905015 ("virtio_net: Add XDP support")
Cc: John Fastabend <john.fastabend at gmail.com>
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
I'm cleaning up a bunch of issues in this code, thus
RFC, will test and post it all together.
drivers/net/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 11773d6..e0fb3707 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -570,7 +570,7 @@ static struct sk_buff *receive_mergeable(struct net_device
*dev,
u16 num_buf;
struct page *page;
int offset;
- struct sk_buff *head_skb, *curr_skb;
+ struct sk_buff *head_skb = NULL, *curr_skb;
struct bpf_prog *xdp_prog;
unsigned int truesize;
--
MST
Reasonably Related Threads
- [PATCH] virtio_net: fix mergeable bufs error handling
- [PATCH] virtio_net: fix mergeable bufs error handling
- [PATCH RFC] virtio_net: fix mergeable bufs error handling
- [PATCH net-next 7/8] virtio_net: introduce receive_mergeable_xdp()
- [PATCH net-next 7/8] virtio_net: introduce receive_mergeable_xdp()
